Changeset 103005 in webkit

Timestamp:

Dec 15, 2011, 5:19:44 PM (14 years ago)

Author:

abarth@webkit.org

Message:

<ruby><div><p><rp> parses incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=74668

Reviewed by Darin Adler.

Source/WebCore:

This patch updates our implementation to match a change to the HTML5
specification regarding how <ruby> elements parse. Previously, <rp>
and similar tags used to pop the stack up to the <ruby> element. Now
the popping does not occur.

Tests: html5lib/runner.html

• html/parser/HTMLTreeBuilder.cpp:

LayoutTests:

Update test results to show progression.

• html5lib/runner-expected.txt:
• platform/chromium/html5lib/runner-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/html5lib/runner-expected.txt (modified) ( previous)
• LayoutTests/platform/chromium/html5lib/runner-expected.txt (modified) ( previous)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/parser/HTMLTreeBuilder.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-15  Adam Barth  <abarth@webkit.org>
+
+        <ruby><div><p><rp> parses incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=74668
+
+        Reviewed by Darin Adler.
+
+        Update test results to show progression.
+
+        * html5lib/runner-expected.txt:
+        * platform/chromium/html5lib/runner-expected.txt:
+
 2011-12-15  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-15  Adam Barth  <abarth@webkit.org>
+
+        <ruby><div><p><rp> parses incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=74668
+
+        Reviewed by Darin Adler.
+
+        This patch updates our implementation to match a change to the HTML5
+        specification regarding how <ruby> elements parse.  Previously, <rp>
+        and similar tags used to pop the stack up to the <ruby> element.  Now
+        the popping does not occur.
+
+        Tests: html5lib/runner.html
+
+        * html/parser/HTMLTreeBuilder.cpp:
+
 2011-12-15  Daniel Sievers  <sievers@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -1001 +1001 @@
         if (m_tree.openElements()->inScope(rubyTag.localName())) {
             m_tree.generateImpliedEndTags();
-            if (!m_tree.currentNode()->hasTagName(rubyTag)) {
+            if (!m_tree.currentNode()->hasTagName(rubyTag))
                 parseError(token);
-                m_tree.openElements()->popUntil(rubyTag.localName());
-            }
         }
         m_tree.insertHTMLElement(token);