Changeset 103040 in webkit

Timestamp:

Dec 16, 2011, 12:28:21 AM (14 years ago)

Author:

Philippe Normand

Message:

[GTK] Rounding errors on 32-bit machines causes tests to fail
​https://bugs.webkit.org/show_bug.cgi?id=72254

Initial patch by ​vanuan@gmail.com.
Reviewed by Martin Robinson.

• Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): Pass additional
CXXFLAGS to autogen in an attempt to harmonize floating point
values between 32-bit and 64-bit architectures.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitdirs.pm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-12-15  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK] Rounding errors on 32-bit machines causes tests to fail
+        https://bugs.webkit.org/show_bug.cgi?id=72254
+
+        Initial patch by vanuan@gmail.com.
+        Reviewed by Martin Robinson.
+
+        * Scripts/webkitdirs.pm:
+        (runAutogenForAutotoolsProjectIfNecessary): Pass additional
+        CXXFLAGS to autogen in an attempt to harmonize floating point
+        values between 32-bit and 64-bit architectures.
+
 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Tools/Scripts/webkitdirs.pm

@@ -1622 +1622 @@
     my $relSourceDir = File::Spec->abs2rel($sourceDir) || ".";
 
+    # Compiler options to keep floating point values consistent
+    # between 32-bit and 64-bit architectures. The options are also
+    # used on Chromium build.
+    determineArchitecture();
+    if ($architecture ne "x86_64") {
+        $ENV{'CXXFLAGS'} = "-march=pentium4 -msse2 -mfpmath=sse";
+    }
+
     # Prefix the command with jhbuild run.
     unshift(@buildArgs, "$relSourceDir/autogen.sh");