Changeset 108248 in webkit

Timestamp:

Feb 20, 2012, 9:24:19 AM (14 years ago)

Author:

andersca@apple.com

Message:

Stop the committer timer when the page is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=78907

Reviewed by Adam Roben.

We don't want the committer timer to fire after the scrolling tree has been invalidated,
so stop the committer timer to prevent it from firing and trying to access the scrolling tree.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-17  Anders Carlsson  <andersca@apple.com>
+
+        Stop the committer timer when the page is destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=78907
+
+        Reviewed by Adam Roben.
+
+        We don't want the committer timer to fire after the scrolling tree has been invalidated,
+        so stop the committer timer to prevent it from firing and trying to access the scrolling tree.
+
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::pageDestroyed):
+
 2012-02-20  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -76 +76 @@
 
 #if ENABLE(THREADED_SCROLLING)
+    m_scrollingTreeStateCommitterTimer.stop();
+
     // Invalidating the scrolling tree will break the reference cycle between the ScrollingCoordinator and ScrollingTree objects.
     ScrollingThread::dispatch(bind(&ScrollingTree::invalidate, m_scrollingTree.release()));