Changeset 118626 in webkit

Timestamp:

May 27, 2012, 7:41:43 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] BackingStore accesses tiles even though it's not active
​https://bugs.webkit.org/show_bug.cgi?id=87563

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-04-18
Reviewed by Antonio Gomes.

There are many scenarios that can call render and cause tile access,
and they used to be rerouted to the direct rendering code when the
backing store was not active. This was thanks to an implicit check for
isActive() by virtue of calling shouldDirectRenderingToWindow() from
render().

If we're using OpenGL for compositing the backing store contents
however, direct rendering is always disabled and we jump right into the
tile based rendering code.

Fixed by adding an explicit check for isActive() in render(), now that
the implicit check in shouldDirectRenderingToWindow() is conditional on
having raster usage.

Since PR136381/bug83131, when OpenGL compositing is used, and the
backing store is not active, it is not in charge of drawing the root
layer. Instead, we switch off the paintingGoesToWindow flag on the root
RenderLayer so no invalidates will reach the ChromeClient or the
BackingStore any more. Instead, invalidations will cause the root
accelerated compositing layer to be repainted. Any BackingStore render
calls while in this state are pointless, and can safely do an early
return.

Reviewed internally by Jakob Petsovits.

PR #150403

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/BackingStore.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/BackingStore.cpp

@@ -1011 +1011 @@
     if (shouldDirectRenderingToWindow())
         return renderDirectToWindow(rect);
+
+    // If direct rendering is off, even though we're not active, someone else
+    // has to render the root layer. There are no tiles available for us to
+    // draw to.
+    if (!isActive())
+        return false;
 
     TileRectList tileRectList = mapFromTransformedContentsToTiles(rect);

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-05-27  Arvid Nilsson  <anilsson@rim.com>
+
+        2012-04-18  Arvid Nilsson  <anilsson@rim.com>
+
+        [BlackBerry] BackingStore accesses tiles even though it's not active
+        https://bugs.webkit.org/show_bug.cgi?id=87563
+
+        Reviewed by Antonio Gomes.
+
+        There are many scenarios that can call render and cause tile access,
+        and they used to be rerouted to the direct rendering code when the
+        backing store was not active. This was thanks to an implicit check for
+        isActive() by virtue of calling shouldDirectRenderingToWindow() from
+        render().
+
+        If we're using OpenGL for compositing the backing store contents
+        however, direct rendering is always disabled and we jump right into the
+        tile based rendering code.
+
+        Fixed by adding an explicit check for isActive() in render(), now that
+        the implicit check in shouldDirectRenderingToWindow() is conditional on
+        having raster usage.
+
+        Since PR136381/bug83131, when OpenGL compositing is used, and the
+        backing store is not active, it is not in charge of drawing the root
+        layer. Instead, we switch off the paintingGoesToWindow flag on the root
+        RenderLayer so no invalidates will reach the ChromeClient or the
+        BackingStore any more. Instead, invalidations will cause the root
+        accelerated compositing layer to be repainted. Any BackingStore render
+        calls while in this state are pointless, and can safely do an early
+        return.
+
+        Reviewed internally by Jakob Petsovits.
+
+        PR #150403
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::render):
+
 2012-05-27  Arvid Nilsson  <anilsson@rim.com>