Changeset 120063 in webkit

Timestamp:

Jun 12, 2012, 5:51:16 AM (13 years ago)

Author:

kbalazs@webkit.org

Message:

[REGRESSION][WTR] Build fail with werror after r120054
​https://bugs.webkit.org/show_bug.cgi?id=88862

Reviewed by Csaba Osztrogonác.

Some static helpers become unused after counterValueForElementById
has moved to Internals. Let's remove them.

• WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
+
+        [REGRESSION][WTR] Build fail with werror after r120054
+        https://bugs.webkit.org/show_bug.cgi?id=88862
+
+        Reviewed by Csaba Osztrogonác.
+
+        Some static helpers become unused after counterValueForElementById
+        has moved to Internals. Let's remove them.
+
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+        (WTR):
+
 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp

@@ -53 +53 @@
 const double LayoutTestController::waitToDumpWatchdogTimerInterval = 6;
 
-static JSValueRef propertyValue(JSContextRef context, JSObjectRef object, const char* propertyName)
-{
-    if (!object)
-        return 0;
-    JSRetainPtr<JSStringRef> propertyNameString(Adopt, JSStringCreateWithUTF8CString(propertyName));
-    JSValueRef exception;
-    return JSObjectGetProperty(context, object, propertyNameString.get(), &exception);
-}
-
-static JSObjectRef propertyObject(JSContextRef context, JSObjectRef object, const char* propertyName)
-{
-    JSValueRef value = propertyValue(context, object, propertyName);
-    if (!value || !JSValueIsObject(context, value))
-        return 0;
-    return const_cast<JSObjectRef>(value);
-}
-
-static JSObjectRef getElementById(WKBundleFrameRef frame, JSStringRef elementId)
-{
-    JSContextRef context = WKBundleFrameGetJavaScriptContext(frame);
-    JSObjectRef document = propertyObject(context, JSContextGetGlobalObject(context), "document");
-    if (!document)
-        return 0;
-    JSValueRef getElementById = propertyObject(context, document, "getElementById");
-    if (!getElementById || !JSValueIsObject(context, getElementById))
-        return 0;
-    JSValueRef elementIdValue = JSValueMakeString(context, elementId);
-    JSValueRef exception;
-    JSValueRef element = JSObjectCallAsFunction(context, const_cast<JSObjectRef>(getElementById), document, 1, &elementIdValue, &exception);
-    if (!element || !JSValueIsObject(context, element))
-        return 0;
-    return const_cast<JSObjectRef>(element);
-}
-
 PassRefPtr<LayoutTestController> LayoutTestController::create()
 {