Changeset 120497 in webkit

Timestamp:

Jun 15, 2012, 3:00:28 PM (13 years ago)

Author:

fischman@chromium.org

Message:

[chromium] Compositor should be aware of |flipped| status of video textures per-platform
​https://bugs.webkit.org/show_bug.cgi?id=89189

Reviewed by James Robinson.

No new tests (sadly HW video decode is still only being tested manually for orientation).

• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-15  Ami Fischman  <fischman@chromium.org>
+
+        [chromium] Compositor should be aware of |flipped| status of video textures per-platform
+        https://bugs.webkit.org/show_bug.cgi?id=89189
+
+        Reviewed by James Robinson.
+
+        No new tests (sadly HW video decode is still only being tested manually for orientation).
+
+        * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
+        (WebCore::CCVideoLayerImpl::appendQuads):
+
 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp

@@ -211 +211 @@
         bool premultipliedAlpha = true;
         FloatRect uvRect(0, 0, 1, 1);
-        bool flipped = false;
+#if defined(OS_CHROMEOS) && defined(__ARMEL__)
+        bool flipped = true; // Under the covers, implemented by OpenMAX IL.
+#elif defined(OS_WINDOWS)
+        bool flipped = true; // Under the covers, implemented by DXVA.
+#else
+        bool flipped = false; // LibVA (cros/intel), MacOS.
+#endif
         OwnPtr<CCTextureDrawQuad> textureQuad = CCTextureDrawQuad::create(sharedQuadState, quadRect, m_frame->textureId(), premultipliedAlpha, uvRect, flipped);
         quadList.append(textureQuad.release());