Changeset 122740 in webkit

Timestamp:

Jul 16, 2012, 11:14:02 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[Android] remove RenderThemeChromiumAndroid::paintMediaFullscreenButton()
​https://bugs.webkit.org/show_bug.cgi?id=91291

Patch by Min Qin <​qinmin@chromium.org> on 2012-07-16
Reviewed by Adam Barth.

The recent media control refactoring added paintMediaFullscreenButton() in RenderThemeChromiumSkia.
Since RenderThemeChromiumAndroid inherits from that class, we don't need to redefine this function.
No test needed as this change just removes an unnecessary override.

• rendering/RenderThemeChromiumAndroid.cpp:
• rendering/RenderThemeChromiumAndroid.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeChromiumAndroid.cpp (modified) (1 diff)
• rendering/RenderThemeChromiumAndroid.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-16  Min Qin  <qinmin@chromium.org>
+
+        [Android] remove RenderThemeChromiumAndroid::paintMediaFullscreenButton()
+        https://bugs.webkit.org/show_bug.cgi?id=91291
+
+        Reviewed by Adam Barth.
+
+        The recent media control refactoring added paintMediaFullscreenButton() in RenderThemeChromiumSkia.
+        Since RenderThemeChromiumAndroid inherits from that class, we don't need to redefine this function.
+        No test needed as this change just removes an unnecessary override.
+
+        * rendering/RenderThemeChromiumAndroid.cpp:
+        * rendering/RenderThemeChromiumAndroid.h:
+
 2012-07-16  Peter Rybin  <peter.rybin@gmail.com>
 

trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp

@@ -88 +88 @@
 }
 
-bool RenderThemeChromiumAndroid::paintMediaFullscreenButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
-{
-#if ENABLE(VIDEO)
-    return RenderMediaControlsChromium::paintMediaControlsPart(MediaEnterFullscreenButton, object, paintInfo, rect);
-#else
-    UNUSED_PARAM(object);
-    UNUSED_PARAM(paintInfo);
-    UNUSED_PARAM(rect);
-    return false;
-#endif
-}
-
 int RenderThemeChromiumAndroid::menuListArrowPadding() const
 {

trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h

@@ -42 +42 @@
     virtual bool delegatesMenuListRendering() const OVERRIDE { return true; }
 
-    virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;
-
 #if ENABLE(VIDEO)
     virtual String extraMediaControlsStyleSheet() OVERRIDE;