Changeset 122975 in webkit

Timestamp:

Jul 18, 2012, 8:13:34 AM (13 years ago)

Author:

kseo@webkit.org

Message:

[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
​https://bugs.webkit.org/show_bug.cgi?id=91595

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-07-18
Reviewed by Noam Rosenthal.

Internal review by Kwang Yul Seo.

Currently, TextureMapperLayer creates an ImageBuffer as big as
m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
consume more memory than the size of the layerRect. It even can cause crash if
m_state.needsDisplayRect is too big.

No new tests, covered by existing tests.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/TextureMapperLayer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-18  Huang Dongsung  <luxtella@company100.net>
+
+        [Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
+        https://bugs.webkit.org/show_bug.cgi?id=91595
+
+        Reviewed by Noam Rosenthal.
+
+        Internal review by Kwang Yul Seo.
+
+        Currently, TextureMapperLayer creates an ImageBuffer as big as
+        m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
+        m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
+        consume more memory than the size of the layerRect. It even can cause crash if
+        m_state.needsDisplayRect is too big.
+
+        No new tests, covered by existing tests.
+
+        * platform/graphics/texmap/TextureMapperLayer.cpp:
+        (WebCore::TextureMapperLayer::updateBackingStore):
+
 2012-07-18  Jason Liu  <jason.liu@torchmobile.com.cn>
 

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp

@@ -109 +109 @@
     }
 
-    IntRect dirtyRect = enclosingIntRect(m_state.needsDisplay ? layerRect() : m_state.needsDisplayRect);
+    IntRect dirtyRect = enclosingIntRect(layerRect());
+    if (!m_state.needsDisplay)
+        dirtyRect.intersect(enclosingIntRect(m_state.needsDisplayRect));
     if (dirtyRect.isEmpty())
         return;