Changeset 124419 in webkit


Ignore:
Timestamp:
Aug 2, 2012, 1:17:13 AM (13 years ago)
Author:
yosin@chromium.org
Message:

Layout Test fast/forms/input-widths.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=92863

Reviewed by Kent Tamura.

This patch removes test cases for "date", "datetime", "datetime-local",
"month", "time" and "week" input types from fast/forms/input-widths.html
and updates its expectation, because these test cases aren't reasonable
any more.

This patch also removes test sample of input type "color".

After r124314, All chromium ports, except for Android, input type
"time" uses "monospace" font which makes input field wider.

  • fast/forms/input-widths-expected.txt: Removed expectation of "date", "datetime", "datetime-local",

"month", "time" and "week" input types.

  • fast/forms/input-widths.html: Removed test cases for "date", "datetime", "datetime-local",

"month", "time" and "week" input types, and a test sample for "color".

  • platform/chromium/TestExpectations: Removed disabling line of fast/forms/input-widths.html
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r124418 r124419  
     12012-08-02  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        Layout Test fast/forms/input-widths.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=92863
     5
     6        Reviewed by Kent Tamura.
     7
     8        This patch removes test cases for "date", "datetime", "datetime-local",
     9        "month", "time" and "week" input types from fast/forms/input-widths.html
     10        and updates its expectation, because these test cases aren't reasonable
     11        any more.
     12
     13        This patch also removes test sample of input type "color".
     14
     15        After r124314, All chromium ports, except for Android, input type
     16        "time" uses "monospace" font which makes input field wider.
     17
     18        * fast/forms/input-widths-expected.txt: Removed expectation of "date", "datetime", "datetime-local",
     19        "month", "time" and "week" input types.
     20        * fast/forms/input-widths.html: Removed test cases for "date", "datetime", "datetime-local",
     21        "month", "time" and "week" input types, and a test sample for "color".
     22        * platform/chromium/TestExpectations: Removed disabling line of fast/forms/input-widths.html
     23
    1242012-08-02  Peter Kasting  <pkasting@google.com>
    225

  • trunk/LayoutTests/fast/forms/input-widths-expected.txt

    r87274 r124419  
    66PASS document.getElementById("tel").offsetWidth is baseWidth
    77PASS document.getElementById("url").offsetWidth is baseWidth
    8 PASS document.getElementById("date").offsetWidth is baseWidth
    9 PASS document.getElementById("datetime").offsetWidth is baseWidth
    10 PASS document.getElementById("datetimelocal").offsetWidth is baseWidth
    11 PASS document.getElementById("month").offsetWidth is baseWidth
    12 PASS document.getElementById("time").offsetWidth is baseWidth
    13 PASS document.getElementById("week").offsetWidth is baseWidth
    148PASS successfullyParsed is true
    159

  • trunk/LayoutTests/fast/forms/input-widths.html

    r98407 r124419  
    1616<input type=tel id=tel>
    1717<input type=url id=url>
    18 
    19 <input type=color id=color>
    20 <input type=date id=date>
    21 <input type=datetime id=datetime>
    22 <input type=datetime-local id=datetimelocal>
    23 <input type=month id=month>
    24 <input type=time id=time>
    25 <input type=week id=week>
    2618</div>
    2719
    … …  
    3729// type=search is not tested intentionally.
    3830
    39 // The folloiwng types should be removed when dedicated UIs are implemented.
    40 shouldBe('document.getElementById("date").offsetWidth', 'baseWidth');
    41 shouldBe('document.getElementById("datetime").offsetWidth', 'baseWidth');
    42 shouldBe('document.getElementById("datetimelocal").offsetWidth', 'baseWidth');
    43 shouldBe('document.getElementById("month").offsetWidth', 'baseWidth');
    44 shouldBe('document.getElementById("time").offsetWidth', 'baseWidth');
    45 shouldBe('document.getElementById("week").offsetWidth', 'baseWidth');
    46 
    4731document.getElementById('parent').innerHTML = '';
    4832</script>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r124418 r124419  
    35083508BUGWK92852 LINUX DEBUG : media/video-currentTime-set2.html = PASS CRASH
    35093509
    3510 // Started failing after http://trac.webkit.org/changeset/124314
    3511 BUGWK92863 : fast/forms/input-widths.html = TEXT
    3512 
    35133510BUGWK92938 : compositing/layer-creation/animation-overlap-with-children.html = TEXT PASS
    35143511
Note: See TracChangeset for help on using the changeset viewer.