Changeset 124973 in webkit

Timestamp:

Aug 7, 2012, 7:52:53 PM (13 years ago)

Author:

dpranke@chromium.org

Message:

REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
​https://bugs.webkit.org/show_bug.cgi?id=93192

Unreviewed, build fix.

Disabling the test for now as PrettyPatch is just broken on win32.

• Scripts/webkitpy/common/prettypatch_unittest.py:

(test_pretty_diff_encodings):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/prettypatch_unittest.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-08-07  Dirk Pranke  <dpranke@chromium.org>
+
+        REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
+        https://bugs.webkit.org/show_bug.cgi?id=93192
+
+        Unreviewed, build fix.
+
+        Disabling the test for now as PrettyPatch is just broken on win32.
+
+        * Scripts/webkitpy/common/prettypatch_unittest.py:
+        (test_pretty_diff_encodings):
+
 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/common/prettypatch_unittest.py

@@ -28 +28 @@
 
 import os.path
+import sys
 import unittest
 
@@ -70 +71 @@
             return
 
+        if sys.platform == 'win32':
+            # FIXME: disabled due to https://bugs.webkit.org/show_bug.cgi?id=93192
+            return
+
         pretty_patch = PrettyPatch(Executive(), self._webkit_root())
         pretty = pretty_patch.pretty_diff(self._diff_with_multiple_encodings)