Changeset 125672 in webkit

Timestamp:

Aug 15, 2012, 6:53:53 AM (13 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=94098

Reviewed by Pavel Feldman.

SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.

• inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._tabClosed):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TabbedEditorContainer.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-15  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
+        https://bugs.webkit.org/show_bug.cgi?id=94098
+
+        Reviewed by Pavel Feldman.
+
+        SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.
+
+        * inspector/front-end/TabbedEditorContainer.js:
+        (WebInspector.TabbedEditorContainer.prototype._tabClosed):
+
 2012-08-15  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js

@@ -293 +293 @@
         var userGesture = /** @type {boolean} */ event.data.isUserGesture;
 
-        this._removeScrollAndSelectionListeners();
         var uiSourceCode = this._files[tabId];
+        if (this._currentFile === uiSourceCode) {
+            this._removeScrollAndSelectionListeners();
+            delete this._currentFile;
+        }
         this._tabIds.remove(uiSourceCode);
         delete this._files[tabId];
-        delete this._currentFile;
 
         uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.TitleChanged, this._uiSourceCodeTitleChanged, this);