Changeset 125789 in webkit


Ignore:
Timestamp:
Aug 16, 2012, 10:20:24 AM (13 years ago)
Author:
enne@google.com
Message:

Make compositing/layer-creation/overflow-scroll-overlap non-flaky
​https://bugs.webkit.org/show_bug.cgi?id=94162

Reviewed by James Robinson.

This test has been failing flakily in Chromium with the scrollbar
layer sometimes being composited and sometimes not. This is likely due
to the video flakily being accelerated depending on whether it has
loaded or not.

Fix this test by making it always have a vertical scrollbar and remove
the video with an always-composited div.

  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap.html:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r125775 r125789  
     12012-08-16  Adrienne Walker  <enne@google.com>
     2
     3        Make compositing/layer-creation/overflow-scroll-overlap non-flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=94162
     5
     6        Reviewed by James Robinson.
     7
     8        This test has been failing flakily in Chromium with the scrollbar
     9        layer sometimes being composited and sometimes not. This is likely due
     10        to the video flakily being accelerated depending on whether it has
     11        loaded or not.
     12
     13        Fix this test by making it always have a vertical scrollbar and remove
     14        the video with an always-composited div.
     15
     16        * compositing/layer-creation/overflow-scroll-overlap-expected.txt:
     17        * compositing/layer-creation/overflow-scroll-overlap.html:
     18        * platform/chromium/TestExpectations:
     19        * platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
     20
    1212012-08-16  Zan Dobersek  <zandobersek@gmail.com>
    222

  • trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt

    r67682 r125789  
    1  (GraphicsLayer
     1(GraphicsLayer
    22  (bounds 800.00 600.00)
    33  (children 1
    … …  
    88          (position 8.00 8.00)
    99          (bounds 30.00 30.00)
    10           (opacity 0.00)
    1110        )
    1211        (GraphicsLayer
    … …  
    1413          (bounds 306.00 206.00)
    1514          (drawsContent 1)
     15          (children 1
     16            (GraphicsLayer
     17              (position 288.00 3.00)
     18              (bounds 15.00 200.00)
     19              (drawsContent 1)
     20            )
     21          )
    1622        )
    1723        (GraphicsLayer

  • trunk/LayoutTests/compositing/layer-creation/overflow-scroll-overlap.html

    r119992 r125789  
    55  <style type="text/css" media="screen">
    66   
    7     video {
     7    .composited {
    88      height: 30px;
    99      width: 30px;
    10       opacity: 0; /* Avoid issues in pixel test */
     10      -webkit-transform:translateZ(0);
    1111    }
    1212   
    … …  
    1515      top: 20px;
    1616      left: 20px;
    17       overflow: auto;
     17      overflow-y: scroll;
    1818      height: 200px;
    1919      width: 300px;
    … …  
    6161<body>
    6262
    63   <video src="../resources/video.mp4" height="20" width="20"></video>
     63  <div class="composited"></div>
    6464
    6565  <div id="scroller" class="overflow">

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r125748 r125789  
    32883288BUGWK88131 DEBUG : fast/dom/HTMLMeterElement/meter-element-crash.html = PASS TEXT
    32893289
    3290 BUGWK67116 DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = PASS TEXT
    3291 
    32923290BUGWK88593 : fast/table/multiple-captions-display.xhtml = PASS IMAGE IMAGE+TEXT
    32933291
Note: See TracChangeset for help on using the changeset viewer.