Changeset 129511 in webkit

Timestamp:

Sep 25, 2012, 8:22:54 AM (13 years ago)

Author:

caseq@chromium.org

Message:

[chromium] adding a page overlay causes endless update loop when accelerated compositing is used
​https://bugs.webkit.org/show_bug.cgi?id=97466

Reviewed by James Robinson.

Do not update overlays in composite() -- doing so ultimately causes invalidation
of the view, hence another update and another call do composite(). Overlays should be
updated only when their content changes.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-09-24  Andrey Kosyakov  <caseq@chromium.org>
+
+        [chromium] adding a page overlay causes endless update loop when accelerated compositing is used
+        https://bugs.webkit.org/show_bug.cgi?id=97466
+
+        Reviewed by James Robinson.
+
+        Do not update overlays in composite() -- doing so ultimately causes invalidation
+        of the view, hence another update and another call do composite(). Overlays should be
+        updated only when their content changes.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::composite):
+
 2012-09-21  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -1823 +1823 @@
             return;
 
-        if (m_pageOverlays)
-            m_pageOverlays->update();
-
         m_layerTreeView->composite();
     }