Changeset 129521 in webkit

Timestamp:

Sep 25, 2012, 10:08:01 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

committers-autocomplete.js works only with WebKit based browsers
​https://bugs.webkit.org/show_bug.cgi?id=66752

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2012-09-25
Reviewed by Darin Adler.

Modified the code do only add event listeners to the given inputs,
and not to the full document.

• committers-autocomplete.js:

Location:

trunk/Websites/bugs.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• committers-autocomplete.js (modified) (1 diff)

trunk/Websites/bugs.webkit.org/ChangeLog

@@ +1 @@
+2012-09-25  Peter Gal  <galpeter@inf.u-szeged.hu>
+
+        committers-autocomplete.js works only with WebKit based browsers
+        https://bugs.webkit.org/show_bug.cgi?id=66752
+
+        Reviewed by Darin Adler.
+
+        Modified the code do only add event listeners to the given inputs,
+        and not to the full document.
+
+        * committers-autocomplete.js:
+
 2012-09-24  Peter Beverloo  <peter@chromium.org>
 

trunk/Websites/bugs.webkit.org/committers-autocomplete.js

@@ -392 +392 @@
     }
 
-    document.addEventListener('focusin', function(e) {
-        for (var i = 0; i < EMAIL_INPUTS.length; i++) {
-            if (e.target.name == EMAIL_INPUTS[i]) {
-                enableAutoComplete(e.target);
-                break;
-            }
-        }
-    }, false);
+    for (var i = 0; i < EMAIL_INPUTS.length; i++) {
+        var field = document.getElementById(EMAIL_INPUTS[i]);
+        if (field)
+            field.addEventListener("focus", function(e) { enableAutoComplete(e.target); }, false);
+    }
 
     WebKitCommitters.getCommitters(function (committers) {