Changeset 130338 in webkit

Timestamp:

Oct 3, 2012, 4:13:56 PM (13 years ago)

Author:

jsbell@chromium.org

Message:

IndexedDB: Don't do full commit for empty transactions
​https://bugs.webkit.org/show_bug.cgi?id=89239

Reviewed by Tony Chang.

Don't bother creating a leveldb write batch if there's nothing in the transaction
to commit. Note that a read-only transaction may still have index cleanup so may
not be an empty transaction.

This cuts the Lookup2 benchmark in ​http://reyesr.github.com/html5-storage-benchmark/
from 70s to 2s.

Covered by existing tests, e.g. storage/indexeddb/transaction-basics.html

• platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::commit):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/leveldb/LevelDBTransaction.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-03  Joshua Bell  <jsbell@chromium.org>
+
+        IndexedDB: Don't do full commit for empty transactions
+        https://bugs.webkit.org/show_bug.cgi?id=89239
+
+        Reviewed by Tony Chang.
+
+        Don't bother creating a leveldb write batch if there's nothing in the transaction
+        to commit. Note that a read-only transaction may still have index cleanup so may
+        not be an empty transaction.
+
+        This cuts the Lookup2 benchmark in http://reyesr.github.com/html5-storage-benchmark/
+        from 70s to 2s.
+
+        Covered by existing tests, e.g. storage/indexeddb/transaction-basics.html
+
+        * platform/leveldb/LevelDBTransaction.cpp:
+        (WebCore::LevelDBTransaction::commit):
+
 2012-10-03  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp

@@ -126 +126 @@
 {
     ASSERT(!m_finished);
+
+    if (m_tree.is_empty()) {
+        m_finished = true;
+        return true;
+    }
+
     OwnPtr<LevelDBWriteBatch> writeBatch = LevelDBWriteBatch::create();