Changeset 131554 in webkit

Timestamp:

Oct 17, 2012, 12:05:46 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Add background color to the radio button theme.
​https://bugs.webkit.org/show_bug.cgi?id=98852

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Background color is added to the radio button theme for identifying
radio button status easily.

Radio button theme uses images which has transparent background.

When the background of radio button is black, checked/unchecked status
cannot be distinguished because check mark color is black.

And it is hard to identify whether the radio button is disabled or not,
because there is no background color in the radio button theme.

• DefaultTheme/widget/radio/img_radio_bg_disabled.png: Added.
• DefaultTheme/widget/radio/img_radio_bg_enabled.png: Added.
• DefaultTheme/widget/radio/radio.edc:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• DefaultTheme/widget/radio/img_radio_bg_disabled.png (added)
• DefaultTheme/widget/radio/img_radio_bg_enabled.png (added)
• DefaultTheme/widget/radio/radio.edc (modified) (4 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-10-17  Byungwoo Lee  <bw80.lee@samsung.com>
+
+        [EFL] Add background color to the radio button theme.
+        https://bugs.webkit.org/show_bug.cgi?id=98852
+
+        Reviewed by Gyuyoung Kim.
+
+        Background color is added to the radio button theme for identifying
+        radio button status easily.
+
+        Radio button theme uses images which has transparent background.
+
+        When the background of radio button is black, checked/unchecked status
+        cannot be distinguished because check mark color is black.
+
+        And it is hard to identify whether the radio button is disabled or not,
+        because there is no background color in the radio button theme.
+
+        * DefaultTheme/widget/radio/img_radio_bg_disabled.png: Added.
+        * DefaultTheme/widget/radio/img_radio_bg_enabled.png: Added.
+        * DefaultTheme/widget/radio/radio.edc:
+
 2012-10-15  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WebKit/efl/DefaultTheme/widget/radio/radio.edc

@@ -25 +25 @@
 
       images {
+         image: "widget/radio/img_radio_bg_enabled.png" COMP;
+         image: "widget/radio/img_radio_bg_disabled.png" COMP;
          image: "widget/radio/img_radio_on.png" COMP;
          image: "widget/radio/img_radio_off.png" COMP;
@@ -43 +45 @@
               if (get_int(isEnabled) == 1) {
                   set_state(PART:"radio_button", "default", 0.0);
+                  set_state(PART:"bg", "enabled", 0.0);
                   if (get_int(isChecked) == 1) {
                       set_state(PART:"radio_button", "enabled_checked", 0.0);
@@ -59 +62 @@
               else {
                   set_state(PART:"radio_button", "disabled", 0.0);
+                  set_state(PART:"bg", "disabled", 0.0);
                   if (get_int(isChecked) == 1)
                       set_state(PART:"radio_button", "disabled_checked", 0.0);
@@ -66 +70 @@
 
       parts {
+         part {
+            name: "bg";
+            type: IMAGE;
+            description {
+               state: "default" 0.0;
+               min: 12 12;
+               max: 12 12;
+               image {
+                  normal: "widget/radio/img_radio_bg_enabled.png";
+               }
+            }
+            description {
+               state: "enabled" 0.0;
+               inherit: "default" 0.0;
+            }
+            description {
+               state: "disabled" 0.0;
+               inherit: "default" 0.0;
+               image {
+                  normal: "widget/radio/img_radio_bg_disabled.png";
+               }
+            }
+         }
          part {
             name: "radio_button";