Changeset 134318 in webkit

Timestamp:

Nov 12, 2012, 3:30:38 PM (13 years ago)

Author:

abarth@webkit.org

Message:

[V8] Many things crash when switching to V8's new aligned pointer API
​https://bugs.webkit.org/show_bug.cgi?id=101994

Reviewed by Eric Seidel.

When using the aligned pointer API, we need to make sure to initialize
every internal field that we later read because the new API has better
error checks than the old API. This patch explicitly initializes the
enteredIsolatedWorldIndex internal field to zero for main worlds,
fixing the LayoutTest crashes from our previous attempt to move the
aligned pointer API.

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-12  Adam Barth  <abarth@webkit.org>
+
+        [V8] Many things crash when switching to V8's new aligned pointer API
+        https://bugs.webkit.org/show_bug.cgi?id=101994
+
+        Reviewed by Eric Seidel.
+
+        When using the aligned pointer API, we need to make sure to initialize
+        every internal field that we later read because the new API has better
+        error checks than the old API. This patch explicitly initializes the
+        enteredIsolatedWorldIndex internal field to zero for main worlds,
+        fixing the LayoutTest crashes from our previous attempt to move the
+        aligned pointer API.
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::V8DOMWindowShell::initializeIfNeeded):
+
 2012-11-12  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -339 +339 @@
     }
 
-    // Flag context as isolated.
-    if (!isMainWorld) {
+    if (isMainWorld)
+        setIsolatedWorldField(0, context);
+    else {
         V8DOMWindowShell* mainWindow = m_frame->script()->existingWindowShell(mainThreadNormalWorld());
         if (mainWindow && !mainWindow->context().IsEmpty())