Changeset 135115 in webkit

Timestamp:

Nov 18, 2012, 11:35:06 PM (13 years ago)

Author:

haraken@chromium.org

Message:

[V8] Remove unused variables from CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=102648

Reviewed by Adam Barth.

No tests. No change in generated code.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateInterface):
(GenerateHeader):
(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementationCustomCall):
(GenerateFunctionCallString):
(CreateCustomSignature):
(GetContextEnableFunction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (16 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-18  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Remove unused variables from CodeGeneratorV8.pm
+        https://bugs.webkit.org/show_bug.cgi?id=102648
+
+        Reviewed by Adam Barth.
+
+        No tests. No change in generated code.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateInterface):
+        (GenerateHeader):
+        (GetInternalFields):
+        (GenerateNormalAttrGetter):
+        (GenerateSingleBatchedAttribute):
+        (GenerateImplementationCustomCall):
+        (GenerateFunctionCallString):
+        (CreateCustomSignature):
+        (GetContextEnableFunction):
+
 2012-11-18  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -38 +38 @@
 my @headerContent = ();
 my @implContentHeader = ();
-my @implFixedHeader = ();
 my @implContent = ();
 my @implContentDecls = ();
@@ -86 +85 @@
     my $object = shift;
     my $dataNode = shift;
-    my $defines = shift;
 
     # Start actual generation
@@ -509 +507 @@
     my $noToV8 = $dataNode->extendedAttributes->{"SuppressToJSObject"};
     my $noWrap = $dataNode->extendedAttributes->{"V8NoWrapperCache"} || $noToV8;
-    my $createWrapperArgumentType = GetPassRefPtrType($nativeType);
     if (!$noWrap) {
         my $createWrapperArgumentType = GetPassRefPtrType($nativeType);
@@ -623 +620 @@
 {
     my $dataNode = shift;
-    my $name = $dataNode->name;
 
     my @customInternalFields = ();
@@ -995 +991 @@
 
     my $result;
-    my $wrapper;
-
     if ($attribute->signature->type eq "EventListener" && $dataNode->name eq "DOMWindow") {
         push(@implContentDecls, "    if (!imp->document())\n");
@@ -2270 +2264 @@
     my $setter;
     my $propAttr = "v8::None";
-    my $hasCustomSetter = 0;
 
     # Check attributes.
@@ -2311 +2304 @@
         # Custom Setter
         if ($attrExt->{"CustomSetter"} || $attrExt->{"V8CustomSetter"} || $attrExt->{"Custom"} || $attrExt->{"V8Custom"}) {
-            $hasCustomSetter = 1;
             $setter = "V8${customAccessor}AccessorSetter";
         }
@@ -2593 +2585 @@
     my $dataNode = shift;
     my $interfaceName = $dataNode->name;
-    my $hasCustomCall = $dataNode->extendedAttributes->{"CustomCall"};
-
-    if ($hasCustomCall) {
+
+    if ($dataNode->extendedAttributes->{"CustomCall"}) {
         push(@implContent, "    desc->InstanceTemplate()->SetCallAsFunctionHandler(V8${interfaceName}::callAsFunctionCallback);\n");
     }
@@ -2619 +2610 @@
 
     # - Add default header template
-    push(@implFixedHeader, GenerateImplementationContentHeader($dataNode));
+    push(@implContentHeader, GenerateImplementationContentHeader($dataNode));
 
     AddToImplIncludes("BindingState.h");
@@ -3197 +3188 @@
     my $conditionalString = $codeGenerator->GenerateConditionalString($dataNode);
     push(@implContent, "\n#endif // ${conditionalString}\n") if $conditionalString;
-    
-    # We've already added the header for this file in implFixedHeader, so remove
+
+    # We've already added the header for this file in implContentHeader, so remove
     # it from implIncludes to ensure we don't #include it twice.
     delete $implIncludes{"${v8InterfaceName}.h"};
@@ -3316 +3307 @@
 
     # - Add default header template
-    push(@implFixedHeader, GenerateImplementationContentHeader($dataNode));
+    push(@implContentHeader, GenerateImplementationContentHeader($dataNode));
 
     AddToImplIncludes("ScriptExecutionContext.h");
@@ -3519 +3510 @@
 
     my $index = 0;
-    my $hasScriptState = 0;
 
     my @arguments;
@@ -3882 +3872 @@
                     AddToImplIncludes("$sequenceType.h");
                 } else {
-                    my $header = GetV8HeaderName($type);
-                    AddToImplIncludes($header);
+                    AddToImplIncludes(GetV8HeaderName($type));
                 }
                 $result .= "V8${type}::GetRawTemplate()";
@@ -4123 +4112 @@
 
     # Update a .cpp file if the contents are changed.
-    my $contents = join "", @implContentHeader, @implFixedHeader;
+    my $contents = join "", @implContentHeader;
 
     my @includes = ();
@@ -4161 +4150 @@
 
     %implIncludes = ();
-    @implFixedHeader = ();
+    @implContentHeader = ();
     @implContentDecls = ();
     @implContent = ();
@@ -4213 +4202 @@
 
     # Or it fallbacks to the attribute name if the parameter value is missing.
-    my $attributeName = $signature->name;
-    return "ContextFeatures::" . $codeGenerator->WK_lcfirst($attributeName) . "Enabled";
+    return "ContextFeatures::" . $codeGenerator->WK_lcfirst($signature->name) . "Enabled";
 }