Context Navigation

← Previous Changeset
Next Changeset →

Changeset 135349 in webkit

Timestamp:

Nov 20, 2012, 9:32:05 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Remove unnecessary #include in API test
https://bugs.webkit.org/show_bug.cgi?id=102674

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
Reviewed by Laszlo Gombos.

Removed duplicated header files from the API test cases.
Now, EWK2UnitTestBase.h includes the basic header files,
so test cases may only include this one and add the addtional
header files if necessary.

UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
UIProcess/API/efl/tests/test_ewk2_context.cpp:
UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
UIProcess/API/efl/tests/test_ewk2_intents.cpp:
UIProcess/API/efl/tests/test_ewk2_object.cpp:
UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
UIProcess/API/efl/tests/test_ewk2_settings.cpp:
UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
UIProcess/API/efl/tests/test_ewk2_view.cpp:

Location:

trunk/Source/WebKit2

Files:

: 23 edited

ChangeLog (modified) (1 diff)
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h (modified) (1 diff)
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h (modified) (1 diff)
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_auth_request.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_color_picker.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_context.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_database_manager.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_download_job.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_intents.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_object.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_settings.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_text_checker.cpp (modified) (1 diff)
UIProcess/API/efl/tests/test_ewk2_view.cpp (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/Source/WebKit2/ChangeLog

-              r135347
+              r135349
+-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
+        [EFL][WK2] Remove unnecessary #include in API test
+        https://bugs.webkit.org/show_bug.cgi?id=102674
+        Reviewed by Laszlo Gombos.
+        Removed duplicated header files from the API test cases.
+        Now, EWK2UnitTestBase.h includes the basic header files,
+        so test cases may only include this one and add the addtional
+        header files if necessary.
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_context.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_intents.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_object.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_view.cpp:
 -11-19  Sam Weinig  <sam@webkit.org>

trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h

-              r134540
+              r135349
 #define EWK2UnitTestBase_h
+#include "EWK2UnitTestEnvironment.h"
 #include <EWebKit2.h>
+#include <Ecore.h>
 #include <Ecore_Evas.h>
+#include <Eina.h>
 #include <Evas.h>
 #include <gtest/gtest.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h

r130373	r135349
20	20	#define EWK2UnitTestEnvironment_h
21	21
22		~~#include <Eina.h>~~
23	22	#include <gtest/gtest.h>
24	23	#include <wtf/text/CString.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp

r131851	r135349
21	21	#include "EWK2UnitTestEnvironment.h"
22	22	#include <getopt.h>
23		~~#include <gtest/gtest.h>~~
24	23
25	24	using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_auth_request.cpp

-              r133673
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 #include <wtf/PassOwnPtr.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp

-              r133278
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
 #include "WKEinaSharedString.h"
-#include <EWebKit2.h>
-#include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp

-              r132617
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp

-              r134042
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp

-              r130871
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp

-              r131417
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <Eina.h>
 #include <stdlib.h>
 #include <unistd.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp

r133692	r135349
27	27
28	28	#include "UnitTestUtils/EWK2UnitTestBase.h"
29		~~#include <EWebKit2.h>~~
30		~~#include <Ecore.h>~~
31	29
32	30	using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp

-              r130637
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 #include <sys/stat.h>
 #include <sys/types.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp

-              r128160
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "WKEinaSharedString.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 #include <WebKit2/WKString.h>
 #include <WebKit2/WKURL.h>
-#include <gtest/gtest.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp

-              r133442
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
 #include "WKEinaSharedString.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp

-              r133744
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp

-              r130843
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_object.cpp

-              r135117
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
 #include "WKEinaSharedString.h"
 #include "ewk_object_private.h"
-#include <EWebKit2.h>
-#include <gtest/gtest.h>
 #include <wtf/PassRefPtr.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp

-              r132535
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp

-              r129892
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore_Evas.h>
-#include <Evas.h>
-#include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp

-              r134760
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Eina.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp

-              r133744
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 using namespace EWK2UnitTest;

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp

-              r131589
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <Eina.h>
 #include <wtf/text/CString.h>
 #include <wtf/text/StringBuilder.h>

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp

-              r133961
+              r135349
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <Eina.h>
-#include <Evas.h>
-#include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 135349 in webkit

Legend:

Download in other formats: