Changeset 136004 in webkit

Timestamp:

Nov 28, 2012, 6:12:30 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Minor cleanup in TestInvocation
​https://bugs.webkit.org/show_bug.cgi?id=103512

Patch by Yael Aharon <​yael.aharon@intel.com> on 2012-11-28
Reviewed by Kenneth Rohde Christiansen.

Remove a function declaration that is not defined and not used.
Fix spelling error in m_webProcessIsUnresponsive.

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):

• WebKitTestRunner/TestInvocation.h:

(TestInvocation):

• WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

• WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestInvocation.cpp (modified) (4 diffs)
• WebKitTestRunner/TestInvocation.h (modified) (2 diffs)
• WebKitTestRunner/cairo/TestInvocationCairo.cpp (modified) (1 diff)
• WebKitTestRunner/qt/TestInvocationQt.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-11-28  Yael Aharon  <yael.aharon@intel.com>
+
+        Minor cleanup in TestInvocation
+        https://bugs.webkit.org/show_bug.cgi?id=103512
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Remove a function declaration that is not defined and not used.
+        Fix spelling error in m_webProcessIsUnresponsive.
+
+        * WebKitTestRunner/TestInvocation.cpp:
+        (WTR::TestInvocation::TestInvocation):
+        (WTR::TestInvocation::invoke):
+        * WebKitTestRunner/TestInvocation.h:
+        (TestInvocation):
+        * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
+        (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+        * WebKitTestRunner/qt/TestInvocationQt.cpp:
+        (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+
 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 

trunk/Tools/WebKitTestRunner/TestInvocation.cpp

@@ -106 +106 @@
     , m_gotRepaint(false)
     , m_error(false)
-    , m_webProcessIsUnrensponsive(false)
+    , m_webProcessIsUnresponsive(false)
 {
 }
@@ -214 +214 @@
     if (!m_gotInitialResponse) {
         m_errorMessage = "Timed out waiting for initial response from web process\n";
-        m_webProcessIsUnrensponsive = true;
+        m_webProcessIsUnresponsive = true;
         goto end;
     }
@@ -230 +230 @@
     if (!m_gotFinalMessage) {
         m_errorMessage = "Timed out waiting for final message from web process\n";
-        m_webProcessIsUnrensponsive = true;
+        m_webProcessIsUnresponsive = true;
         goto end;
     }
@@ -244 +244 @@
 #endif // ENABLE(INSPECTOR)
 
-    if (m_webProcessIsUnrensponsive)
+    if (m_webProcessIsUnresponsive)
         dumpWebProcessUnresponsiveness();
     else if (!TestController::shared().resetStateToConsistentValues()) {

trunk/Tools/WebKitTestRunner/TestInvocation.h

@@ -54 +54 @@
 #if PLATFORM(QT) || PLATFORM(EFL)
     static void forceRepaintDoneCallback(WKErrorRef, void* context);
-    void forceRepaintDone();
 #endif
     
@@ -73 +72 @@
     WKRetainPtr<WKArrayRef> m_repaintRects;
     std::string m_errorMessage;
-    bool m_webProcessIsUnrensponsive;
+    bool m_webProcessIsUnresponsive;
 
 };

trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp

@@ -130 +130 @@
         m_error = true;
         m_errorMessage = "Timed out waiting for repaint\n";
-        m_webProcessIsUnrensponsive = true;
+        m_webProcessIsUnresponsive = true;
         return;
     }

trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp

@@ -86 +86 @@
             m_error = true;
             m_errorMessage = "Timed out waiting for repaint\n";
-            m_webProcessIsUnrensponsive = true;
+            m_webProcessIsUnresponsive = true;
             return;
         }