Changeset 138000 in webkit

Timestamp:

Dec 18, 2012, 2:03:20 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Network: display JavaScript stack in case of script initiator.
​https://bugs.webkit.org/show_bug.cgi?id=104899

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2012-12-18
Reviewed by Vsevolod Vlasov.

Show popup with navigavle stack-trace.

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._getPopoverAnchor):
Added new target.
(WebInspector.NetworkLogView.prototype._showPopover):
Added case for new target.
(WebInspector.NetworkLogView.prototype._generateScriptInitiatedPopoverContent):
Generates table with stack trace items.
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Added target marker, removed annoying titles.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/NetworkPanel.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-18  Eugene Klyuchnikov  <eustas@chromium.org>
+
+        Web Inspector: Network: display JavaScript stack in case of script initiator.
+        https://bugs.webkit.org/show_bug.cgi?id=104899
+
+        Reviewed by Vsevolod Vlasov.
+
+        Show popup with navigavle stack-trace.
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkLogView.prototype._getPopoverAnchor):
+        Added new target.
+        (WebInspector.NetworkLogView.prototype._showPopover):
+        Added case for new target.
+        (WebInspector.NetworkLogView.prototype._generateScriptInitiatedPopoverContent):
+        Generates table with stack trace items.
+        (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
+        Added target marker, removed annoying titles.
+
 2012-12-18  Tamas Czene  <tczene@inf.u-szeged.hu>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -926 +926 @@
             return;
         var anchor = element.enclosingNodeOrSelfWithClass("network-graph-bar") || element.enclosingNodeOrSelfWithClass("network-graph-label");
-        if (!anchor)
-            return null;
-        var request = anchor.parentElement.request;
-        return request && request.timing ? anchor : null;
+        if (anchor && anchor.parentElement.request && anchor.parentElement.request.timing)
+            return anchor;
+        anchor = element.enclosingNodeOrSelfWithClass("network-script-initiated");
+        if (anchor && anchor.request && anchor.request.initiator)
+            return anchor;
+
+        return null;
     },
 
@@ -938 +941 @@
     _showPopover: function(anchor, popover)
     {
-        var request = anchor.parentElement.request;
-        var tableElement = WebInspector.RequestTimingView.createTimingTable(request);
-        popover.show(tableElement, anchor);
+        var content;
+        if (anchor.hasStyleClass("network-script-initiated"))
+            content = this._generateScriptInitiatedPopoverContent(anchor.request);
+        else
+            content = WebInspector.RequestTimingView.createTimingTable(anchor.parentElement.request);
+        popover.show(content, anchor);
+    },
+
+    /**
+     * @param {!WebInspector.NetworkRequest} request
+     * @return {!Element}
+     */
+    _generateScriptInitiatedPopoverContent: function(request)
+    {
+        var stackTrace = request.initiator.stackTrace;
+        var framesTable = document.createElement("table");
+        for (var i = 0; i < stackTrace.length; ++i) {
+            var stackFrame = stackTrace[i];
+            var row = document.createElement("tr");
+            row.createChild("td").textContent = stackFrame.functionName ? stackFrame.functionName : WebInspector.UIString("(anonymous function)");
+            row.createChild("td").textContent = " @ ";
+            row.createChild("td").appendChild(this._linkifier.linkifyLocation(stackFrame.url, stackFrame.lineNumber - 1, 0));
+            framesTable.appendChild(row);
+        }
+        return framesTable;
     },
 
@@ -2011 +2036 @@
     _refreshInitiatorCell: function()
     {
+        this._initiatorCell.removeStyleClass("network-dim-cell");
+        this._initiatorCell.removeStyleClass("network-script-initiated");
+        delete this._initiatorCell.request;
+        this._initiatorCell.title = null;
+
         var initiator = this._request.initiator;
         if ((initiator && initiator.type !== "other") || this._request.redirectSource) {
-            this._initiatorCell.removeStyleClass("network-dim-cell");
             this._initiatorCell.removeChildren();
             if (this._request.redirectSource) {
@@ -2028 +2057 @@
                     return;
                 }
-                this._initiatorCell.title = topFrame.url + ":" + topFrame.lineNumber;
                 var urlElement = this._parentView._linkifier.linkifyLocation(topFrame.url, topFrame.lineNumber - 1, 0);
+                urlElement.title = null;
                 this._initiatorCell.appendChild(urlElement);
                 this._appendSubtitle(this._initiatorCell, WebInspector.UIString("Script"));
+                this._initiatorCell.addStyleClass("network-script-initiated");
+                this._initiatorCell.request = this._request;
             } else { // initiator.type === "parser"
                 this._initiatorCell.title = initiator.url + ":" + initiator.lineNumber;