Changeset 142653 in webkit

Timestamp:

Feb 12, 2013, 12:23:04 PM (12 years ago)

Author:

jsbell@chromium.org

Message:

[Chromium] IndexedDB/Worker crash during shutdown
​https://bugs.webkit.org/show_bug.cgi?id=109467

Reviewed by Tony Chang.

If the message queue has already been terminated, don't bother scheduling
a new error event that will never be delivered. Speculative fix for the
issue, which only repros in multiprocess ports and so far only on some
platforms.

• src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/IDBFactoryBackendProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-12  Joshua Bell  <jsbell@chromium.org>
+
+        [Chromium] IndexedDB/Worker crash during shutdown
+        https://bugs.webkit.org/show_bug.cgi?id=109467
+
+        Reviewed by Tony Chang.
+
+        If the message queue has already been terminated, don't bother scheduling
+        a new error event that will never be delivered. Speculative fix for the
+        issue, which only repros in multiprocess ports and so far only on some
+        platforms.
+
+        * src/IDBFactoryBackendProxy.cpp:
+        (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.
+
 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp

@@ -183 +183 @@
         if (runLoop.runInMode(workerContext, mode) == MessageQueueTerminated) {
             bridge->cancel();
-            allowed = false;
-        } else
-            allowed = bridge->result();
+            return false;
+        }
+        allowed = bridge->result();
     }