Changeset 143736 in webkit

Timestamp:

Feb 22, 2013, 8:51:50 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=110567

Patch by Carlos Garcia Campos <​cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

They were removed from ChromeClient in r122810 and are now
implemented in NavigatorContentUtilsClientBlackBerry since r131056.

• WebCoreSupport/ChromeClientBlackBerry.cpp:
• WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientBlackBerry.cpp (modified) (1 diff)
• WebCoreSupport/ChromeClientBlackBerry.h (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-02-22  Carlos Garcia Campos  <cargarcia@rim.com>
+
+        [BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
+        https://bugs.webkit.org/show_bug.cgi?id=110567
+
+        Reviewed by Rob Buis.
+
+        They were removed from ChromeClient in r122810 and are now
+        implemented in NavigatorContentUtilsClientBlackBerry since r131056.
+
+        * WebCoreSupport/ChromeClientBlackBerry.cpp:
+        * WebCoreSupport/ChromeClientBlackBerry.h:
+        (ChromeClientBlackBerry):
+
 2013-02-22  Xan Lopez  <xlopez@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

@@ -824 +824 @@
 }
 
-#if ENABLE(NAVIGATOR_CONTENT_UTILS)
-void ChromeClientBlackBerry::registerProtocolHandler(const String& scheme, const String& baseURL, const String& url, const String& title)
-{
-    m_webPagePrivate->m_client->registerProtocolHandler(scheme, baseURL, url, title);
-}
-
-#if ENABLE(CUSTOM_SCHEME_HANDLER)
-ChromeClient::CustomHandlersState ChromeClientBlackBerry::isProtocolHandlerRegistered(const String& scheme, const String& baseURL, const String& url)
-{
-    return static_cast<CustomHandlersState>(m_webPagePrivate->m_client->isProtocolHandlerRegistered(scheme, baseURL, url));
-}
-
-void ChromeClientBlackBerry::unregisterProtocolHandler(const String& scheme, const String& baseURL, const String& url)
-{
-    m_webPagePrivate->m_client->unregisterProtocolHandler(scheme, baseURL, url);
-}
-#endif
-#endif
-
 void ChromeClientBlackBerry::addSearchProvider(const BlackBerry::Platform::String& originURL, const BlackBerry::Platform::String& newURL)
 {

trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h

@@ -152 +152 @@
 #endif
 
-#if ENABLE(NAVIGATOR_CONTENT_UTILS)
-    virtual void registerProtocolHandler(const String& /*scheme*/, const String& /*baseURL*/, const String& /*url*/, const String& /*title*/);
-
-#if ENABLE(CUSTOM_SCHEME_HANDLER)
-    virtual CustomHandlersState isProtocolHandlerRegistered(const String& /*scheme*/, const String& /*baseURL*/, const String& /*url*/);
-    virtual void unregisterProtocolHandler(const String& /*scheme*/, const String& /*baseURL*/, const String& /*url*/);
-#endif
-#endif
-
     virtual void addSearchProvider(const BlackBerry::Platform::String&, const BlackBerry::Platform::String&);
     virtual int isSearchProviderInstalled(const BlackBerry::Platform::String&, const BlackBerry::Platform::String&);