Changeset 145707 in webkit

Timestamp:

Mar 13, 2013, 5:48:28 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: [CodeMirror] token highlight still has some problems
​https://bugs.webkit.org/show_bug.cgi?id=112173

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Use pseudo elements with borders to draw token highlight.

No new tests.

• inspector/front-end/cm/cmdevtools.css:

(.cm-token-highlight):
(.cm-token-highlight:before):
(.cm-line-with-selection .cm-column-with-selection:before):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/cm/cmdevtools.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-13  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: [CodeMirror] token highlight still has some problems
+        https://bugs.webkit.org/show_bug.cgi?id=112173
+
+        Reviewed by Vsevolod Vlasov.
+
+        Use pseudo elements with borders to draw token highlight.
+
+        No new tests.
+
+        * inspector/front-end/cm/cmdevtools.css:
+        (.cm-token-highlight):
+        (.cm-token-highlight:before):
+        (.cm-line-with-selection .cm-column-with-selection:before):
+
 2013-03-13  Alberto Garcia  <agarcia@igalia.com>
 

trunk/Source/WebCore/inspector/front-end/cm/cmdevtools.css

@@ -52 +52 @@
 
 .cm-token-highlight {
+    position: relative;
+}
+
+.cm-token-highlight:before {
+    position: absolute;
     border: 1px solid gray;
     border-radius: 3px;
-    margin: -1px;
+    top: 0px;
+    bottom: 0px;
+    left: 0px;
+    right: 0px;
+    content: "";
 }
 
-.cm-line-with-selection .cm-column-with-selection {
+.cm-line-with-selection .cm-column-with-selection:before {
     border: 0px;
-    margin: 0px;
 }