Changeset 146628 in webkit

Timestamp:

Mar 22, 2013, 10:34:20 AM (12 years ago)

Author:

dgrogan@chromium.org

Message:

IndexedDB: Histogram available disk space on attempt to open database
​https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Tony Chang.

Source/Platform:

• chromium/public/Platform.h:

(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

Location:

trunk/Source

Files:

• Platform/ChangeLog (modified) (1 diff)
• Platform/chromium/public/Platform.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/leveldb/LevelDBDatabase.cpp (modified) (3 diffs)

trunk/Source/Platform/ChangeLog

@@ +1 @@
+2013-03-22  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: Histogram available disk space on attempt to open database
+        https://bugs.webkit.org/show_bug.cgi?id=112862
+
+        Reviewed by Tony Chang.
+
+        * chromium/public/Platform.h:
+        (WebKit::Platform::availableDiskSpaceInBytes):
+        (Platform):
+
 2013-03-22  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Source/Platform/chromium/public/Platform.h

@@ -359 +359 @@
     // Callable from a background WebKit thread.
     virtual void callOnMainThread(void (*func)(void*), void* context) { }
+
+    // Checks the partition/volume where fileName resides.
+    virtual long long availableDiskSpaceInBytes(const WebString& fileName) { return 0; }
 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-22  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: Histogram available disk space on attempt to open database
+        https://bugs.webkit.org/show_bug.cgi?id=112862
+
+        Reviewed by Tony Chang.
+
+        ChromeOS suspects they might be hitting disk corruption when the disks
+        are nearly full. This patch logs the available space to either the
+        "success" or the "fail" histogram as appropriate so that the
+        distributions can be compared.
+
+        No new tests - I don't know of a good way to test histograms. Local
+        printf testing didn't turn up any bugs.
+
+        * platform/leveldb/LevelDBDatabase.cpp:
+        (WebCore::HistogramFreeSpace):
+        (WebCore):
+        (WebCore::LevelDBDatabase::open):
+
 2013-03-22  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

@@ -47 +47 @@
 #if PLATFORM(CHROMIUM)
 #include <env_idb.h>
+#include <public/Platform.h>
 #endif
 
@@ -141 +142 @@
     const leveldb::Status s = leveldb::DestroyDB(fileName.utf8().data(), options);
     return s.ok();
+}
+
+static void histogramFreeSpace(const char* type, String fileName)
+{
+#if PLATFORM(CHROMIUM)
+    String name = "WebCore.IndexedDB.LevelDB.Open" + String(type) + "FreeDiskSpace";
+    long long freeDiskSpaceInKBytes = WebKit::Platform::current()->availableDiskSpaceInBytes(fileName) / 1024;
+    if (freeDiskSpaceInKBytes < 0) {
+        HistogramSupport::histogramEnumeration("WebCore.IndexedDB.LevelDB.FreeDiskSpaceFailure", 1/*sample*/, 2/*boundary*/);
+        return;
+    }
+    int clampedDiskSpaceKBytes = freeDiskSpaceInKBytes > INT_MAX ? INT_MAX : freeDiskSpaceInKBytes;
+    const uint64_t histogramMax = static_cast<uint64_t>(1e9);
+    COMPILE_ASSERT(histogramMax <= INT_MAX, histogramMaxTooBig);
+    HistogramSupport::histogramCustomCounts(name.utf8().data(), clampedDiskSpaceKBytes, 1, histogramMax, 11/*buckets*/);
+#endif
 }
 
@@ -167 +184 @@
         HistogramSupport::histogramEnumeration("WebCore.IndexedDB.LevelDBOpenErrors", levelDBError, LevelDBMaxError);
 
+        histogramFreeSpace("Failure", fileName);
+
         LOG_ERROR("Failed to open LevelDB database from %s: %s", fileName.ascii().data(), s.ToString().c_str());
         return nullptr;
     }
+
+    histogramFreeSpace("Success", fileName);
 
     OwnPtr<LevelDBDatabase> result = adoptPtr(new LevelDBDatabase);