Changeset 150513 in webkit

Timestamp:

May 22, 2013, 6:45:15 AM (12 years ago)

Author:

Hugo Parente Lima

Message:

WebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
​https://bugs.webkit.org/show_bug.cgi?id=116340

Reviewed by Christophe Dumez.

No new tests, just a simple build fix.

• inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::setDOMStorageItem): Init frame variable.
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): Init frame variable.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorDOMStorageAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-22  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        WebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
+        https://bugs.webkit.org/show_bug.cgi?id=116340
+
+        Reviewed by Christophe Dumez.
+
+        No new tests, just a simple build fix.
+
+        * inspector/InspectorDOMStorageAgent.cpp:
+        (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): Init frame variable.
+        (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): Init frame variable.
+
 2013-05-22  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 

trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp

@@ -199 +199 @@
         if (errorString)
             *errorString = "Invalid storageId format";
+        targetFrame = 0;
         return 0;
     }
 
-    Frame* frame = m_pageAgent->findFrameWithSecurityOrigin(securityOrigin);
-    if (!frame) {
+    targetFrame = m_pageAgent->findFrameWithSecurityOrigin(securityOrigin);
+    if (!targetFrame) {
         if (errorString)
             *errorString = "Frame not found for the given security origin";
         return 0;
     }
-    targetFrame = frame;
 
     Page* page = m_pageAgent->page();
     if (isLocalStorage)
-        return page->group().localStorage()->storageArea(frame->document()->securityOrigin());
-    return page->sessionStorage()->storageArea(frame->document()->securityOrigin());
+        return page->group().localStorage()->storageArea(targetFrame->document()->securityOrigin());
+    return page->sessionStorage()->storageArea(targetFrame->document()->securityOrigin());
 }