Changeset 151603 in webkit


Ignore:
Timestamp:
Jun 14, 2013, 1:02:46 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] Remove implementation of ContextMenu classes
​https://bugs.webkit.org/show_bug.cgi?id=114860

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-06-14
Reviewed by Rob Buis.

This code is not being used so we can safely remove it.

Source/WebCore:

  • PlatformBlackBerry.cmake:
  • platform/blackberry/ContextMenuBlackBerry.cpp: Removed.
  • platform/blackberry/ContextMenuItemBlackBerry.cpp: Removed.
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
  • WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
Location:
trunk/Source
Files:
4 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r151601 r151603  
     12013-06-14  Alberto Garcia  <agarcia@igalia.com>
     2
     3        [BlackBerry] Remove implementation of ContextMenu classes
     4        https://bugs.webkit.org/show_bug.cgi?id=114860
     5
     6        Reviewed by Rob Buis.
     7
     8        This code is not being used so we can safely remove it.
     9
     10        * PlatformBlackBerry.cmake:
     11        * platform/blackberry/ContextMenuBlackBerry.cpp: Removed.
     12        * platform/blackberry/ContextMenuItemBlackBerry.cpp: Removed.
     13        * platform/blackberry/LocalizedStringsBlackBerry.cpp:
     14
    1152013-06-14  Brent Fulgham  <bfulgham@apple.com>
    216

  • trunk/Source/WebCore/PlatformBlackBerry.cmake

    r151507 r151603  
    9494    page/blackberry/EventHandlerBlackBerry.cpp
    9595    page/blackberry/SettingsBlackBerry.cpp
    96     platform/blackberry/ContextMenuBlackBerry.cpp
    97     platform/blackberry/ContextMenuItemBlackBerry.cpp
    9896    platform/blackberry/CursorBlackBerry.cpp
    9997    platform/blackberry/DragDataBlackBerry.cpp

  • trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp

    r150362 r151603  
    8282}
    8383
    84 #if ENABLE(CONTEXT_MENUS)
    85 String contextMenuItemTagBold()
    86 {
    87     notImplemented();
    88     return String();
    89 }
    90 
    91 String contextMenuItemTagCheckGrammarWithSpelling()
    92 {
    93     notImplemented();
    94     return String();
    95 }
    96 
    97 String contextMenuItemTagCheckSpelling()
    98 {
    99     notImplemented();
    100     return String();
    101 }
    102 
    103 String contextMenuItemTagCheckSpellingWhileTyping()
    104 {
    105     notImplemented();
    106     return String();
    107 }
    108 
    109 String contextMenuItemTagCopyImageToClipboard()
    110 {
    111     notImplemented();
    112     return String();
    113 }
    114 
    115 String contextMenuItemTagCopyLinkToClipboard()
    116 {
    117     notImplemented();
    118     return String();
    119 }
    120 
    121 String contextMenuItemTagDefaultDirection()
    122 {
    123     notImplemented();
    124     return String();
    125 }
    126 
    127 String contextMenuItemTagDownloadImageToDisk()
    128 {
    129     notImplemented();
    130     return String();
    131 }
    132 
    133 String contextMenuItemTagDownloadLinkToDisk()
    134 {
    135     notImplemented();
    136     return String();
    137 }
    138 
    139 String contextMenuItemTagFontMenu()
    140 {
    141     notImplemented();
    142     return String();
    143 }
    144 
    145 String contextMenuItemTagIgnoreGrammar()
    146 {
    147     notImplemented();
    148     return String();
    149 }
    150 
    151 String contextMenuItemTagIgnoreSpelling()
    152 {
    153     notImplemented();
    154     return String();
    155 }
    156 
    157 String contextMenuItemTagInspectElement()
    158 {
    159     notImplemented();
    160     return String();
    161 }
    162 
    163 String contextMenuItemTagItalic()
    164 {
    165     notImplemented();
    166     return String();
    167 }
    168 
    169 String contextMenuItemTagLearnSpelling()
    170 {
    171     notImplemented();
    172     return String();
    173 }
    174 
    175 String contextMenuItemTagLeftToRight()
    176 {
    177     notImplemented();
    178     return String();
    179 }
    180 
    181 String contextMenuItemTagNoGuessesFound()
    182 {
    183     notImplemented();
    184     return String();
    185 }
    186 
    187 String contextMenuItemTagOpenFrameInNewWindow()
    188 {
    189     notImplemented();
    190     return String();
    191 }
    192 
    193 String contextMenuItemTagOpenImageInNewWindow()
    194 {
    195     notImplemented();
    196     return String();
    197 }
    198 
    199 String contextMenuItemTagOpenLinkInNewWindow()
    200 {
    201     notImplemented();
    202     return String();
    203 }
    204 
    205 String contextMenuItemTagOpenLink()
    206 {
    207     notImplemented();
    208     return String();
    209 }
    210 
    211 String contextMenuItemTagOutline()
    212 {
    213     notImplemented();
    214     return String();
    215 }
    216 
    217 String contextMenuItemTagReload()
    218 {
    219     notImplemented();
    220     return String();
    221 }
    222 
    223 String contextMenuItemTagRightToLeft()
    224 {
    225     notImplemented();
    226     return String();
    227 }
    228 
    229 String contextMenuItemTagSearchWeb()
    230 {
    231     notImplemented();
    232     return String();
    233 }
    234 
    235 String contextMenuItemTagShowSpellingPanel(bool)
    236 {
    237     notImplemented();
    238     return String();
    239 }
    240 
    241 String contextMenuItemTagSpellingMenu()
    242 {
    243     notImplemented();
    244     return String();
    245 }
    246 
    247 String contextMenuItemTagTextDirectionMenu()
    248 {
    249     notImplemented();
    250     return String();
    251 }
    252 
    253 String contextMenuItemTagUnderline()
    254 {
    255     notImplemented();
    256     return String();
    257 }
    258 
    259 String contextMenuItemTagWritingDirectionMenu()
    260 {
    261     notImplemented();
    262     return String();
    263 }
    264 
    265 String contextMenuItemTagCopyVideoLinkToClipboard()
    266 {
    267     notImplemented();
    268     return String();
    269 }
    270 
    271 String contextMenuItemTagOpenVideoInNewWindow()
    272 {
    273     notImplemented();
    274     return String();
    275 }
    276 
    277 String contextMenuItemTagToggleMediaControls()
    278 {
    279     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_MEDIA_TOGGLE_CONTROLS));
    280 }
    281 
    282 String contextMenuItemTagToggleMediaLoop()
    283 {
    284     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_MEDIA_TOGGLE_LOOP));
    285 }
    286 
    287 String contextMenuItemTagEnterVideoFullscreen()
    288 {
    289     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_VIDEO_FULLSCREEN));
    290 }
    291 
    292 String contextMenuItemTagMediaPlay()
    293 {
    294     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_MEDIA_PLAY));
    295 }
    296 
    297 String contextMenuItemTagMediaPause()
    298 {
    299     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_MEDIA_PAUSE));
    300 }
    301 
    302 String contextMenuItemTagMediaMute()
    303 {
    304     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_MEDIA_MUTE));
    305 }
    306 
    307 String contextMenuItemTagCopyAudioLinkToClipboard()
    308 {
    309     notImplemented();
    310     return String();
    311 }
    312 
    313 String contextMenuItemTagOpenAudioInNewWindow()
    314 {
    315     notImplemented();
    316     return String();
    317 }
    318 
    319 String contextMenuItemTagGoBack()
    320 {
    321     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_GOBACK));
    322 }
    323 
    324 String contextMenuItemTagGoForward()
    325 {
    326     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_GOFORWARD));
    327 }
    328 
    329 String contextMenuItemTagStop()
    330 {
    331     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_STOP));
    332 }
    333 
    334 String contextMenuItemTagCopy()
    335 {
    336     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_COPY));
    337 }
    338 
    339 String contextMenuItemTagCut()
    340 {
    341     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_CUT));
    342 }
    343 
    344 String contextMenuItemTagPaste()
    345 {
    346     return String::fromUTF8(s_resource.getString(BlackBerry::Platform::CONTEXT_PASTE));
    347 }
    348 
    349 #endif
    350 
    35184String searchableIndexIntroduction()
    35285{

  • trunk/Source/WebKit/ChangeLog

    r151568 r151603  
     12013-06-14  Alberto Garcia  <agarcia@igalia.com>
     2
     3        [BlackBerry] Remove implementation of ContextMenu classes
     4        https://bugs.webkit.org/show_bug.cgi?id=114860
     5
     6        Reviewed by Rob Buis.
     7
     8        This code is not being used so we can safely remove it.
     9
     10        * PlatformBlackBerry.cmake:
     11
    1122013-06-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
    213

  • trunk/Source/WebKit/PlatformBlackBerry.cmake

    r150767 r151603  
    8787    blackberry/WebCoreSupport/CacheClientBlackBerry.cpp
    8888    blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
    89     blackberry/WebCoreSupport/ContextMenuClientBlackBerry.cpp
    9089    blackberry/WebCoreSupport/CredentialManager.cpp
    9190    blackberry/WebCoreSupport/CredentialTransformData.cpp

  • trunk/Source/WebKit/blackberry/Api/WebPage.cpp

    r151507 r151603  
    3434#include "Chrome.h"
    3535#include "ChromeClientBlackBerry.h"
    36 #include "ContextMenuClientBlackBerry.h"
    3736#include "CookieManager.h"
    3837#include "CredentialManager.h"
    … …  
    521520
    522521    ChromeClientBlackBerry* chromeClient = new ChromeClientBlackBerry(this);
    523 #if ENABLE(CONTEXT_MENUS)
    524     ContextMenuClientBlackBerry* contextMenuClient = 0;
    525     contextMenuClient = new ContextMenuClientBlackBerry();
    526 #endif
    527522    EditorClientBlackBerry* editorClient = new EditorClientBlackBerry(this);
    528523    DragClientBlackBerry* dragClient = 0;
    … …  
    538533    Page::PageClients pageClients;
    539534    pageClients.chromeClient = chromeClient;
    540 #if ENABLE(CONTEXT_MENUS)
    541     pageClients.contextMenuClient = contextMenuClient;
    542 #endif
    543535    pageClients.editorClient = editorClient;
    544536    pageClients.dragClient = dragClient;

  • trunk/Source/WebKit/blackberry/ChangeLog

    r151595 r151603  
     12013-06-14  Alberto Garcia  <agarcia@igalia.com>
     2
     3        [BlackBerry] Remove implementation of ContextMenu classes
     4        https://bugs.webkit.org/show_bug.cgi?id=114860
     5
     6        Reviewed by Rob Buis.
     7
     8        This code is not being used so we can safely remove it.
     9
     10        * Api/WebPage.cpp:
     11        (BlackBerry::WebKit::WebPagePrivate::init):
     12        * WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
     13        * WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
     14
    1152013-06-14  Arvid Nilsson  <anilsson@rim.com>
    216
Note: See TracChangeset for help on using the changeset viewer.