Changeset 151762 in webkit

Timestamp:

Jun 19, 2013, 7:18:07 PM (12 years ago)

Author:

ap@apple.com

Message:

[Mac] Common crashes when playing media
​https://bugs.webkit.org/show_bug.cgi?id=117813
<rdar://problem/13837412>

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): This method may be called from a secondary thread, but it does things that are not thread safe.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-19  Alexey Proskuryakov  <ap@apple.com>
+
+        [Mac] Common crashes when playing media
+        https://bugs.webkit.org/show_bug.cgi?id=117813
+        <rdar://problem/13837412>
+
+        Reviewed by Eric Carlson.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
+        This method may be called from a secondary thread, but it does things that are
+        not thread safe.
+
 2013-06-19  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -1710 +1710 @@
         return;
 
-    return m_callback->didCancelLoadingRequest(loadingRequest);
+    dispatch_async(dispatch_get_main_queue(), ^{
+        if (m_callback)
+            m_callback->didCancelLoadingRequest(loadingRequest);
+    });
 }