Changeset 153084 in webkit

Timestamp:

Jul 24, 2013, 7:53:31 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] [WK2] Handle wheel event with delta zero
​https://bugs.webkit.org/show_bug.cgi?id=118973

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-07-24
Reviewed by Gustavo Noronha Silva.

Added handling of zero mouse scroll deltas in EventSenderProxy similar
to WK1 and Qt/EFL ports.

fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
failing on WK2.

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::mouseScrollBy):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
+
+        [GTK] [WK2] Handle wheel event with delta zero
+        https://bugs.webkit.org/show_bug.cgi?id=118973
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Added handling of zero mouse scroll deltas in EventSenderProxy similar
+        to WK1 and Qt/EFL ports.
+
+        fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
+        failing on WK2.
+
+        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+        (WTR::EventSenderProxy::mouseScrollBy):
+
 2013-07-23  Andreas Kling  <akling@apple.com>
 

trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp

@@ -378 +378 @@
 void EventSenderProxy::mouseScrollBy(int horizontal, int vertical)
 {
+    // Copy behaviour of Qt and EFL - just return in case of (0,0) mouse scroll
+    if (!horizontal && !vertical)
+        return;
+
     GdkEvent* event = gdk_event_new(GDK_SCROLL);
     event->scroll.x = m_position.x;