Changeset 153091 in webkit

Timestamp:

Jul 24, 2013, 11:28:40 AM (12 years ago)

Author:

Antoine Quint

Message:

Web Inspector: control+clicking on a numeric token should not show the context menu
​https://bugs.webkit.org/show_bug.cgi?id=119048

Reviewed by Timothy Hatcher.

Track "contextmenu" events when we're hovering a token containing a numeric value
and call preventDefault() in the event handler to ensure that the context menu does
not appear.

• UserInterface/CodeMirrorDragToAlterNumberController.js:

(WebInspector.CodeMirrorDragToAlterNumberController.prototype.handleEvent):
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._setTracksMouseClickAndDrag):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/CodeMirrorDragToAlterNumberController.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2013-07-24  Antoine Quint  <graouts@apple.com>
+
+        Web Inspector: control+clicking on a numeric token should not show the context menu
+        https://bugs.webkit.org/show_bug.cgi?id=119048
+
+        Reviewed by Timothy Hatcher.
+
+        Track "contextmenu" events when we're hovering a token containing a numeric value
+        and call preventDefault() in the event handler to ensure that the context menu does
+        not appear.
+
+        * UserInterface/CodeMirrorDragToAlterNumberController.js:
+        (WebInspector.CodeMirrorDragToAlterNumberController.prototype.handleEvent):
+        (WebInspector.CodeMirrorDragToAlterNumberController.prototype._setTracksMouseClickAndDrag):
+
 2013-07-24  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.js

@@ -81 +81 @@
             this._mouseWasReleased(event);
             break;
+        case "contextmenu":
+            event.preventDefault();
+            break;
         }
     },
@@ -126 +129 @@
             this._element.classList.add(WebInspector.CodeMirrorDragToAlterNumberController.StyleClassName);
             window.addEventListener("mousedown", this, true);
+            window.addEventListener("contextmenu", this, true);
         } else {
             this._element.classList.remove(WebInspector.CodeMirrorDragToAlterNumberController.StyleClassName);
             window.removeEventListener("mousedown", this, true);
+            window.removeEventListener("contextmenu", this, true);
             this._setDragging(false);
         }