Changeset 155101 in webkit

Timestamp:

Sep 5, 2013, 12:18:58 AM (12 years ago)

Author:

fpizlo@apple.com

Message:

Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.

• Scripts/run-javascriptcore-tests:

(readAllLines):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-09-05  Filip Pizlo  <fpizlo@apple.com>
+
+        Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
+
+        * Scripts/run-javascriptcore-tests:
+        (readAllLines):
+
 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -32 +32 @@
 
 use strict;
-use File::Slurp;
 use FindBin;
 use Getopt::Long qw(:config pass_through);
@@ -217 +216 @@
 }
 
+sub readAllLines
+{
+    my ($filename) = @_;
+    my @array = ();
+    eval {
+        open FILE, $filename or die;
+        while (<FILE>) {
+            push @array, $_;
+        }
+        close FILE;
+    };
+    return @array;
+}
+
 sub printThingsFound
 {
@@ -229 +242 @@
 }
 
-my @fastJSFailList = eval { read_file($fastJSResultsDir . "/failed") };
-my @fastJSCrashList = eval { read_file($fastJSResultsDir . "/crashed") };
+my @fastJSFailList = readAllLines($fastJSResultsDir . "/failed");
+my @fastJSCrashList = readAllLines($fastJSResultsDir . "/crashed");
 my $numJSFailures = @fastJSFailList;
 my $numJSCrashes = @fastJSCrashList;