Changeset 157201 in webkit

Timestamp:

Oct 9, 2013, 6:23:46 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
​https://bugs.webkit.org/show_bug.cgi?id=122552

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-10-09
Reviewed by Darin Adler.

• Scripts/webkitpy/common/checkout/commitinfo.py:

(CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
will cause UnicodeDecodeError for non-ascii characters.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/commitinfo.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
+
+        webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
+        https://bugs.webkit.org/show_bug.cgi?id=122552
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitpy/common/checkout/commitinfo.py:
+        (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
+        will cause UnicodeDecodeError for non-ascii characters.
+
 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/checkout/commitinfo.py

@@ -95 +95 @@
         string += "  Bug: %s (%s)\n" % (self.bug_id(), bugs.bug_url_for_bug_id(self.bug_id()))
         author_line = "\"%s\" <%s>" % (self.author_name(), self.author_email())
-        string += "  Author: %s\n" % (self.author() or author_line)
-        string += "  Reviewer: %s\n" % (self.reviewer() or self.reviewer_text())
-        string += "  Committer: %s" % self.committer()
+        string += "  Author: %s\n" % unicode(self.author() or author_line)
+        string += "  Reviewer: %s\n" % unicode(self.reviewer() or self.reviewer_text())
+        string += "  Committer: %s" % unicode(self.committer())
         return string