Changeset 15968 in webkit

Timestamp:

Aug 22, 2006, 11:56:33 AM (19 years ago)

Author:

rwlbuis

Message:

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
REPRO: SVG crashes inside gradient code

Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/gradient-attr-update-expected.checksum (added)
• LayoutTests/svg/custom/gradient-attr-update-expected.png (added)
• LayoutTests/svg/custom/gradient-attr-update-expected.txt (added)
• LayoutTests/svg/custom/gradient-attr-update.svg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/ksvg2/svg/SVGGradientElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-08-22  Rob Buis  <buis@kde.org>
+
+        Reviewed by Eric.
+
+        Testcase for:
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
+        REPRO: SVG crashes inside gradient code
+
+        * svg/custom/gradient-attr-update-expected.checksum: Added.
+        * svg/custom/gradient-attr-update-expected.png: Added.
+        * svg/custom/gradient-attr-update-expected.txt: Added.
+        * svg/custom/gradient-attr-update.svg: Added.
+
 2006-08-22  Rob Buis  <buis@kde.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-08-22  Rob Buis  <buis@kde.org>
+
+        Reviewed by Eric.
+
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
+        REPRO: SVG crashes inside gradient code
+
+        Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.
+
+        * ksvg2/svg/SVGGradientElement.cpp:
+        (SVGGradientElement::notifyAttributeChange):
+        (SVGGradientElement::resourceNotification):
+
 2006-08-22  David Harrison  <harrison@apple.com>
 

trunk/WebCore/ksvg2/svg/SVGGradientElement.cpp

@@ -104 +104 @@
 void SVGGradientElement::notifyAttributeChange() const
 {
-    if(ownerDocument()->parsing() || !attached())
+    if(ownerDocument()->parsing() || !attached() || !m_resource)
         return;
 
@@ -136 +136 @@
 {
     // We're referenced by a "client", build the gradient now...
-    buildGradient(m_resource);
+    buildGradient(const_cast<SVGGradientElement*>(this)->canvasResource());
 }