Changeset 160051 in webkit

Timestamp:

Dec 3, 2013, 3:26:46 PM (12 years ago)

Author:

fpizlo@apple.com

Message:

REGRESSION: repro scripts disappear when you rerun tests
​https://bugs.webkit.org/show_bug.cgi?id=125184

Reviewed by Mark Hahnenberg.

This bug made it difficult to quickly see if a test that recently failed is still
failing while also running a new batch of tests.

Repro scripts are supposed to stay around until you delete them explicitly. This
patch accomplishes that.

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-12-03  Filip Pizlo  <fpizlo@apple.com>
+
+        REGRESSION: repro scripts disappear when you rerun tests
+        https://bugs.webkit.org/show_bug.cgi?id=125184
+
+        Reviewed by Mark Hahnenberg.
+        
+        This bug made it difficult to quickly see if a test that recently failed is still
+        failing while also running a new batch of tests.
+
+        Repro scripts are supposed to stay around until you delete them explicitly. This
+        patch accomplishes that.
+
+        * Scripts/run-jsc-stress-tests:
+
 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -908 +908 @@
 def eachResultFile(startingDir, &block)
     dirsToClean = [startingDir]
-    until dirsToClean.empty? do
+    until dirsToClean.empty?
         nextDir = dirsToClean.pop
         Dir.foreach(nextDir) {
@@ -1140 +1140 @@
 end
 
-FileUtils.rm_rf $outputDir if $outputDir.directory? and not $bundle
+def clean(file)
+    FileUtils.rm_rf file unless $bundle
+end
+
+clean($outputDir + "failed")
+clean($outputDir + ".vm")
+clean($outputDir + ".runner")
+clean($outputDir + ".tests")
+clean($outputDir + "_payload")
+
 Dir.mkdir($outputDir) unless $outputDir.directory?
-
-begin
-    File.delete($outputDir + "failed")
-rescue
-end
 
 $outputDir = $outputDir.realpath
@@ -1153 +1157 @@
 prepareBundle unless $bundle
 
-puts " "
+puts
 
 prepareTestRunner unless $bundle