Changeset 160052 in webkit

Timestamp:

Dec 3, 2013, 3:28:10 PM (12 years ago)

Author:

timothy_horton@apple.com

Message:

Remote Layer Tree: Force repaint
​https://bugs.webkit.org/show_bug.cgi?id=125189
<rdar://problem/15541789>

Reviewed by Anders Carlsson.

• WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::forceRepaint):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
Implement WebProcess-synchronous force repaint.
We don't need the async variant because it is only needed
to synchronize with the WebProcess-side threaded scrolling
tree, which is not a component of the remote layer tree model.
The UI process will not handle the callback until after
RemoteLayerTreeHost::commit is complete, ensuring that the commit
is actually done.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/mac/RemoteLayerTreeContext.h (modified) (1 diff)
• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm (modified) (2 diffs)
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (modified) (1 diff)
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-03  Tim Horton  <timothy_horton@apple.com>
+
+        Remote Layer Tree: Force repaint
+        https://bugs.webkit.org/show_bug.cgi?id=125189
+        <rdar://problem/15541789>
+
+        Reviewed by Anders Carlsson.
+
+        * WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
+        * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
+        (WebKit::RemoteLayerTreeContext::forceRepaint):
+        * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
+        * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+        (WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
+        Implement WebProcess-synchronous force repaint.
+        We don't need the async variant because it is only needed
+        to synchronize with the WebProcess-side threaded scrolling
+        tree, which is not a component of the remote layer tree model.
+        The UI process will not handle the callback until after
+        RemoteLayerTreeHost::commit is complete, ensuring that the commit
+        is actually done.
+
 2013-12-03  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h

@@ -59 +59 @@
     void setIsFlushingSuspended(bool);
 
+    void forceRepaint();
+
 private:
     // WebCore::GraphicsLayerFactory

trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm

@@ -27 +27 @@
 #import "RemoteLayerTreeContext.h"
 
+#import "GenericCallback.h"
 #import "GraphicsLayerCARemote.h"
 #import "PlatformCALayerRemote.h"
@@ -152 +153 @@
 }
 
+void RemoteLayerTreeContext::forceRepaint()
+{
+    if (m_isFlushingSuspended)
+        return;
+
+    for (Frame* frame = &m_webPage->corePage()->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+        FrameView* frameView = frame->view();
+        if (!frameView || !frameView->tiledBacking())
+            continue;
+
+        frameView->tiledBacking()->forceRepaint();
+    }
+
+    flushLayers();
+}
+
 } // namespace WebKit

trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h

@@ -67 +67 @@
     virtual void setLayerTreeStateIsFrozen(bool) OVERRIDE;
 
+    virtual void forceRepaint() OVERRIDE;
+    virtual bool forceRepaintAsync(uint64_t) OVERRIDE { return false; }
+
     // WebCore::GraphicsLayerClient
     virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) OVERRIDE { }

trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm

@@ -203 +203 @@
 }
 
+void RemoteLayerTreeDrawingArea::forceRepaint()
+{
+    m_remoteLayerTreeContext->forceRepaint();
+}
+
 } // namespace WebKit