Changeset 160086 in webkit

Timestamp:

Dec 4, 2013, 3:20:45 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
​https://bugs.webkit.org/show_bug.cgi?id=124731

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Zoltan Herczeg.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-12-04  László Langó  <lango@inf.u-szeged.hu>
+
+        check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
+        https://bugs.webkit.org/show_bug.cgi?id=124731
+
+        Reviewed by Zoltan Herczeg.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_spacing):
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+        (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
+
 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -1843 +1843 @@
         if not search(r'<[^<]*,\s*$', line):  # template params spill
             matched = search(r'[^<>=!\s](<)[^<>=!\s]([^>]|->)*$', line)
-    if matched:
+    # It is necessary to check this, because rvaule references can be in
+    # parameter packs (c++11 feature)
+    if matched and not search(r'&&\.\.\.', line):
         error(line_number, 'whitespace/operators', 3,
               'Missing spaces around %s' % matched.group(1))

trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

@@ -629 +629 @@
         self.assert_lint('T&&', '')
 
+    def test_rvaule_reference_in_parameter_pack(self):
+        self.assert_lint('void requestCompleted(Arguments&&... arguments)', '')
 
 class CppStyleTest(CppStyleTestBase):