Changeset 161203 in webkit

Timestamp:

Jan 1, 2014, 7:22:05 PM (12 years ago)

Author:

akling@apple.com

Message:

Remove ChromeClient::fullScreenRendererChanged().
<​https://webkit.org/b/126370>

This hook was added in r75277 to notify WebFullScreenController when
the full screen renderer changed. In r110216 the code was refactored,
making this notification unnecessary.

Reviewed by Antti Koivisto.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (2 diffs)
• WebCore/page/ChromeClient.h (modified) (1 diff)
• WebKit/mac/WebCoreSupport/WebChromeClient.h (modified) (1 diff)
• WebKit/mac/WebCoreSupport/WebChromeClient.mm (modified) (1 diff)
• WebKit/mac/WebView/WebViewInternal.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-01  Andreas Kling  <akling@apple.com>
+
+        Remove ChromeClient::fullScreenRendererChanged().
+        <https://webkit.org/b/126370>
+
+        This hook was added in r75277 to notify WebFullScreenController when
+        the full screen renderer changed. In r110216 the code was refactored,
+        making this notification unnecessary.
+
+        Reviewed by Antti Koivisto.
+
 2014-01-01  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5466 +5466 @@
 
     m_fullScreenRenderer = renderer;
-    
-    // This notification can come in after the page has been destroyed.
-    if (page())
-        page()->chrome().client().fullScreenRendererChanged(m_fullScreenRenderer);
 }
 
@@ -5475 +5471 @@
 {
     m_fullScreenRenderer = nullptr;
-
-    if (page())
-        page()->chrome().client().fullScreenRendererChanged(nullptr);
 }
 

trunk/Source/WebCore/page/ChromeClient.h

@@ -336 +336 @@
     virtual void enterFullScreenForElement(Element*) { }
     virtual void exitFullScreenForElement(Element*) { }
-    virtual void fullScreenRendererChanged(RenderBox*) { }
     virtual void setRootFullScreenLayer(GraphicsLayer*) { }
 #endif

trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h

@@ -192 +192 @@
     virtual void enterFullScreenForElement(WebCore::Element*) OVERRIDE;
     virtual void exitFullScreenForElement(WebCore::Element*) OVERRIDE;
-    virtual void fullScreenRendererChanged(WebCore::RenderBox*) OVERRIDE;
 #endif
 

trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm

@@ -1033 +1033 @@
 }
 
-void WebChromeClient::fullScreenRendererChanged(RenderBox* renderer)
-{
-    SEL selector = @selector(webView:fullScreenRendererChanged:);
-    if ([[m_webView UIDelegate] respondsToSelector:selector])
-        CallUIDelegate(m_webView, selector, (id)renderer);
-}
-
-#endif
+#endif

trunk/Source/WebKit/mac/WebView/WebViewInternal.h

@@ -246 +246 @@
 - (void)_enterFullScreenForElement:(WebCore::Element*)element;
 - (void)_exitFullScreenForElement:(WebCore::Element*)element;
-- (void)_fullScreenRendererChanged:(WebCore::RenderBox*)renderer;
 #endif