Changeset 161261 in webkit


Ignore:
Timestamp:
Jan 3, 2014, 9:00:50 AM (12 years ago)
Author:
ap@apple.com
Message:

Provide a visual clue when element has a popover at build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=126281

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:

(PopoverTracker): Add a class name to elements with popovers.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(*): We have -webkit-user-select:none, so let's also not show text selection cursor.
I might have broke that recently.
(*:link): Show hand cursor over links.
(.popover-tracking:hover): Put a shadow on hover over element with popovers.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line .message .revision-number): Show text selection cursor on our only
selectable text element.
(.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
a white shadow than with a dark one on hover.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js

    r161124 r161261  
    3636    this._active = false;
    3737
     38    element.classList.add("popover-tracking");
    3839    element.addEventListener("mouseenter", this._mouseEnteredPopoverOrElement.bind(this), true);
    3940    element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css

    r161124 r161261  
    2828    -webkit-user-select: none;
    2929    -webkit-user-drag: none;
     30    cursor: default;
     31}
     32
     33*:link {
     34    cursor: pointer;
    3035}
    3136
    … …  
    192197}
    193198
     199.popover-tracking:hover {
     200    text-shadow: 0px 0px 3px rgba(0, 0, 0, 0.2)
     201}

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css

    r161131 r161261  
    104104.status-line .message .revision-number {
    105105    -webkit-user-select: auto;
     106    cursor: text;
    106107}
    107108
    … …  
    135136    color: rgb(191, 67, 41);
    136137}
     138
     139.status-line .bubble.popover-tracking:hover {
     140    text-shadow: 0px 0px 5px rgba(255, 255, 255, 0.7)
     141}

  • trunk/Tools/ChangeLog

    r161256 r161261  
     12014-01-03  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Provide a visual clue when element has a popover at build.webkit.org/dashboard
     4        https://bugs.webkit.org/show_bug.cgi?id=126281
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
     9        (PopoverTracker): Add a class name to elements with popovers.
     10
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
     12        (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
     13        I might have broke that recently.
     14        (*:link): Show hand cursor over links.
     15        (.popover-tracking:hover): Put a shadow on hover over element with popovers.
     16
     17        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
     18        (.status-line .message .revision-number): Show text selection cursor on our only
     19        selectable text element.
     20        (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
     21        a white shadow than with a dark one on hover.
     22
    1232014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
    224
Note: See TracChangeset for help on using the changeset viewer.