Changeset 161278 in webkit

Timestamp:

Jan 3, 2014, 12:22:09 PM (12 years ago)

Author:

akling@apple.com

Message:

Deploy more child renderer iterators in RenderBlockFlow.
<​https://webkit.org/b/126434>

Reviewed by Sam Weinig.

• rendering/RenderBlockFlow.cpp:

(WebCore::shouldCheckLines):

Make this helper take a RenderBlockFlow instead of a RenderObject
and simplified it a bit. RenderDeprecatedFlexibleBox does not
derive from RenderBlockFlow so those checks can be omitted.

(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::lineAtIndex):
(WebCore::RenderBlockFlow::lineCount):
(WebCore::RenderBlockFlow::clearTruncation):

Use childrenOfType to iterate over block and block-flow children.
Tweaked some early return/continue to reduce nesting.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockFlow.cpp (modified) (7 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-03  Andreas Kling  <akling@apple.com>
+
+        Deploy more child renderer iterators in RenderBlockFlow.
+        <https://webkit.org/b/126434>
+
+        Reviewed by Sam Weinig.
+
+        * rendering/RenderBlockFlow.cpp:
+        (WebCore::shouldCheckLines):
+
+            Make this helper take a RenderBlockFlow instead of a RenderObject
+            and simplified it a bit. RenderDeprecatedFlexibleBox does not
+            derive from RenderBlockFlow so those checks can be omitted.
+
+        (WebCore::RenderBlockFlow::layoutBlock):
+        (WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
+        (WebCore::RenderBlockFlow::lineAtIndex):
+        (WebCore::RenderBlockFlow::lineCount):
+        (WebCore::RenderBlockFlow::clearTruncation):
+
+            Use childrenOfType to iterate over block and block-flow children.
+            Tweaked some early return/continue to reduce nesting.
+
 2014-01-03  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlockFlow.cpp

@@ -387 +387 @@
         if (oldHeight > newHeight && maxFloatLogicalBottom > newHeight && !childrenInline()) {
             // One of our children's floats may have become an overhanging float for us. We need to look for it.
-            for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-                if (child->isRenderBlockFlow() && !child->isFloatingOrOutOfFlowPositioned()) {
-                    RenderBlockFlow& block = toRenderBlockFlow(*child);
-                    if (block.lowestFloatLogicalBottom() + block.logicalTop() > newHeight)
-                        addOverhangingFloats(block, false);
-                }
+            for (auto& blockFlow : childrenOfType<RenderBlockFlow>(*this)) {
+                if (blockFlow.isFloatingOrOutOfFlowPositioned())
+                    continue;
+                if (blockFlow.lowestFloatLogicalBottom() + blockFlow.logicalTop() > newHeight)
+                    addOverhangingFloats(blockFlow, false);
             }
         }
@@ -2463 +2462 @@
         removeFloatingObject(*floatToRemove);
 
+    if (childrenInline())
+        return;
+
     // Iterate over our children and mark them as needed.
-    if (!childrenInline()) {
-        for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-            if ((!floatToRemove && child->isFloatingOrOutOfFlowPositioned()) || !child->isRenderBlock())
-                continue;
-            if (!child->isRenderBlockFlow()) {
-                RenderBlock* childBlock = toRenderBlock(child);
-                if (childBlock->shrinkToAvoidFloats() && childBlock->everHadLayout())
-                    childBlock->setChildNeedsLayout(markParents);
-                continue;
-            }
-            RenderBlockFlow* childBlock = toRenderBlockFlow(child);
-            if ((floatToRemove ? childBlock->containsFloat(*floatToRemove) : childBlock->containsFloats()) || childBlock->shrinkToAvoidFloats())
-                childBlock->markAllDescendantsWithFloatsForLayout(floatToRemove, inLayout);
-        }
+    for (auto& block : childrenOfType<RenderBlock>(*this)) {
+        if (!floatToRemove && block.isFloatingOrOutOfFlowPositioned())
+            continue;
+        if (!block.isRenderBlockFlow()) {
+            if (block.shrinkToAvoidFloats() && block.everHadLayout())
+                block.setChildNeedsLayout(markParents);
+            continue;
+        }
+        auto& blockFlow = toRenderBlockFlow(block);
+        if ((floatToRemove ? blockFlow.containsFloat(*floatToRemove) : blockFlow.containsFloats()) || blockFlow.shrinkToAvoidFloats())
+            blockFlow.markAllDescendantsWithFloatsForLayout(floatToRemove, inLayout);
     }
 }
@@ -2863 +2862 @@
 }
 
-static bool shouldCheckLines(RenderObject& obj)
-{
-    return !obj.isFloatingOrOutOfFlowPositioned() && !obj.isRunIn() && obj.isRenderBlockFlow() && obj.style().height().isAuto() && (!obj.isDeprecatedFlexibleBox() || obj.style().boxOrient() == VERTICAL);
+static bool shouldCheckLines(const RenderBlockFlow& blockFlow)
+{
+    return !blockFlow.isFloatingOrOutOfFlowPositioned() && !blockFlow.isRunIn() && blockFlow.style().height().isAuto();
 }
 
@@ -2880 +2879 @@
                 return box;
         }
-    } else {
-        for (auto child = firstChild(); child; child = child->nextSibling()) {
-            if (!shouldCheckLines(*child))
-                continue;
-            if (RootInlineBox* box = toRenderBlockFlow(child)->lineAtIndex(i))
-                return box;
-        }
+        return nullptr;
+    }
+
+    for (auto& blockFlow : childrenOfType<RenderBlockFlow>(*this)) {
+        if (!shouldCheckLines(blockFlow))
+            continue;
+        if (RootInlineBox* box = blockFlow.lineAtIndex(i))
+            return box;
     }
 
@@ -2908 +2908 @@
             }
         }
-    } else {
-        for (auto child = firstChild(); child; child = child->nextSibling()) {
-            if (shouldCheckLines(*child)) {
-                bool recursiveFound = false;
-                count += toRenderBlockFlow(child)->lineCount(stopRootInlineBox, &recursiveFound);
-                if (recursiveFound) {
-                    if (found)
-                        *found = true;
-                    break;
-                }
-            }
+        return count;
+    }
+
+    for (auto& blockFlow : childrenOfType<RenderBlockFlow>(*this)) {
+        if (!shouldCheckLines(blockFlow))
+            continue;
+        bool recursiveFound = false;
+        count += blockFlow.lineCount(stopRootInlineBox, &recursiveFound);
+        if (recursiveFound) {
+            if (found)
+                *found = true;
+            break;
         }
     }
@@ -2938 +2939 @@
         RenderBox* normalFlowChildWithoutLines = 0;
         for (auto obj = block.firstChildBox(); obj; obj = obj->nextSiblingBox()) {
-            if (shouldCheckLines(*obj)) {
+            if (obj->isRenderBlockFlow() && shouldCheckLines(toRenderBlockFlow(*obj))) {
                 int result = getHeightForLineCount(toRenderBlockFlow(*obj), lineCount, false, count);
                 if (result != -1)
@@ -2969 +2970 @@
         for (auto box = firstRootBox(); box; box = box->nextRootBox())
             box->clearTruncation();
-    } else {
-        for (auto child = firstChild(); child; child = child->nextSibling()) {
-            if (shouldCheckLines(*child))
-                toRenderBlockFlow(child)->clearTruncation();
-        }
+        return;
+    }
+
+    for (auto& blockFlow : childrenOfType<RenderBlockFlow>(*this)) {
+        if (shouldCheckLines(blockFlow))
+            blockFlow.clearTruncation();
     }
 }