Changeset 161702 in webkit

Timestamp:

Jan 10, 2014, 5:09:58 PM (12 years ago)

Author:

dino@apple.com

Message:

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
​https://bugs.webkit.org/show_bug.cgi?id=126754

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".

• js/script-tests/typedarray-constructors.js: Added.
• js/typedarray-constructors-expected.txt: Added.
• js/typedarray-constructors.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/script-tests/typedarray-constructors.js (added)
• LayoutTests/js/typedarray-constructors-expected.txt (added)
• LayoutTests/js/typedarray-constructors.html (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-01-10  Dean Jackson  <dino@apple.com>
+
+        [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
+        https://bugs.webkit.org/show_bug.cgi?id=126754
+
+        Reviewed by Filip Pizlo.
+
+        New test which checks that we throw an exception when calling
+        any of the typed array constructors without using "new".
+
+        * js/script-tests/typedarray-constructors.js: Added.
+        * js/typedarray-constructors-expected.txt: Added.
+        * js/typedarray-constructors.html: Added.
+
 2014-01-10  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-10  Dean Jackson  <dino@apple.com>
+
+        [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
+        https://bugs.webkit.org/show_bug.cgi?id=126754
+
+        Reviewed by Filip Pizlo.
+
+        The ECMAScript specification forbids calling the typed array
+        constructors without using "new". Change the call data to return
+        none so we throw and exception in these cases.
+
+        * runtime/JSGenericTypedArrayViewConstructorInlines.h:
+        (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
+
 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h

@@ -158 +158 @@
 {
     callData.native.function = constructGenericTypedArrayView<ViewClass>;
-    return CallTypeHost;
+    return CallTypeNone;
 }