Changeset 162999 in webkit

Timestamp:

Jan 28, 2014, 8:44:56 PM (12 years ago)

Author:

jer.noble@apple.com

Message:

[Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
​https://bugs.webkit.org/show_bug.cgi?id=127806

Reviewed by Eric Carlson.

In addition to the normal "user/password" NSURLAuthenticationChallenges, the
-resourceLoader:shouldWaitForResponseToAuthenticationChallenge: delegate method will
ask us to confirm server certificate chains. Rather than pop up an authentication
dialog (which won't work anyway) we will now just drop such requests and continue
on normally.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-28  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
+        https://bugs.webkit.org/show_bug.cgi?id=127806
+
+        Reviewed by Eric Carlson.
+
+        In addition to the normal "user/password" NSURLAuthenticationChallenges, the 
+        -resourceLoader:shouldWaitForResponseToAuthenticationChallenge: delegate method will
+        ask us to confirm server certificate chains. Rather than pop up an authentication
+        dialog (which won't work anyway) we will now just drop such requests and continue
+        on normally.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
+
 2014-01-28  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -2102 +2102 @@
         return NO;
 
+    if ([[[challenge protectionSpace] authenticationMethod] isEqualToString:NSURLAuthenticationMethodServerTrust])
+        return NO;
+
     RetainPtr<WebCoreAVFLoaderDelegate> strongSelf = self;
     RetainPtr<NSURLAuthenticationChallenge> strongChallenge = challenge;