Changeset 164084 in webkit


Ignore:
Timestamp:
Feb 13, 2014, 5:59:29 PM (11 years ago)
Author:
mmaxfield@apple.com
Message:

Remove position:sticky runtime flag
​https://bugs.webkit.org/show_bug.cgi?id=128774

Reviewed by Simon Fraser.

Rollout of r128663

No new tests are necessary because there is no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSParserMode.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r164076 r164084  
     12014-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Remove position:sticky runtime flag
     4        https://bugs.webkit.org/show_bug.cgi?id=128774
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rollout of r128663
     9
     10        No new tests are necessary because there is no behavior change.
     11
     12        * css/CSSParser.cpp:
     13        (WebCore::CSSParserContext::CSSParserContext):
     14        (WebCore::operator==):
     15        (WebCore::isValidKeywordPropertyAndValue):
     16        * css/CSSParserMode.h:
     17        * dom/Document.cpp:
     18        * dom/Document.h:
     19        * page/Settings.cpp:
     20        (WebCore::Settings::Settings):
     21        * page/Settings.h:
     22
    1232014-02-04  Gustavo Noronha Silva  <gns@gnome.org>
    224

  • trunk/Source/WebCore/css/CSSParser.cpp

    r164061 r164084  
    246246    , mode(mode)
    247247    , isHTMLDocument(false)
    248     , isCSSStickyPositionEnabled(false)
    249248    , isCSSRegionsEnabled(false)
    250249    , isCSSCompositingEnabled(false)
    … …  
    267266    , mode(document.inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
    268267    , isHTMLDocument(document.isHTMLDocument())
    269     , isCSSStickyPositionEnabled(document.cssStickyPositionEnabled())
    270268    , isCSSRegionsEnabled(document.cssRegionsEnabled())
    271269    , isCSSCompositingEnabled(document.cssCompositingEnabled())
    … …  
    289287        && a.mode == b.mode
    290288        && a.isHTMLDocument == b.isHTMLDocument
    291         && a.isCSSStickyPositionEnabled == b.isCSSStickyPositionEnabled
    292289        && a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
    293290        && a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
    … …  
    752749        if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed
    753750#if ENABLE(CSS_STICKY_POSITION)
    754             || (parserContext.isCSSStickyPositionEnabled && valueID == CSSValueWebkitSticky)
     751            || valueID == CSSValueWebkitSticky
    755752#endif
    756753            )

  • trunk/Source/WebCore/css/CSSParserMode.h

    r162644 r164084  
    6565    CSSParserMode mode;
    6666    bool isHTMLDocument;
    67     bool isCSSStickyPositionEnabled;
    6867    bool isCSSRegionsEnabled;
    6968    bool isCSSCompositingEnabled;

  • trunk/Source/WebCore/dom/Document.cpp

    r164036 r164084  
    10831083}
    10841084
    1085 bool Document::cssStickyPositionEnabled() const
    1086 {
    1087     return settings() && settings()->cssStickyPositionEnabled();
    1088 }
    1089 
    10901085bool Document::cssRegionsEnabled() const
    10911086{

  • trunk/Source/WebCore/dom/Document.h

    r164036 r164084  
    395395    PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
    396396
    397     bool cssStickyPositionEnabled() const;
    398397    bool cssRegionsEnabled() const;
    399398    bool cssCompositingEnabled() const;

  • trunk/Source/WebCore/page/Settings.cpp

    r163983 r164084  
    190190    , m_alwaysUseAcceleratedOverflowScroll(false)
    191191#endif
    192 #if ENABLE(CSS_STICKY_POSITION)
    193     , m_cssStickyPositionEnabled(true)
    194 #endif
    195192    , m_showTiledScrollingIndicator(false)
    196193    , m_tiledBackingStoreEnabled(false)

  • trunk/Source/WebCore/page/Settings.h

    r163983 r164084  
    213213    FontRenderingMode fontRenderingMode() const;
    214214
    215 #if ENABLE(CSS_STICKY_POSITION)
    216     void setCSSStickyPositionEnabled(bool enabled) { m_cssStickyPositionEnabled = enabled; }
    217     bool cssStickyPositionEnabled() const { return m_cssStickyPositionEnabled; }
    218 #else
    219     void setCSSStickyPositionEnabled(bool) { }
    220     bool cssStickyPositionEnabled() const { return false; }
    221 #endif
    222 
    223215    void setShowTiledScrollingIndicator(bool);
    224216    bool showTiledScrollingIndicator() const { return m_showTiledScrollingIndicator; }
    … …  
    354346    bool m_alwaysUseAcceleratedOverflowScroll : 1;
    355347#endif
    356 #if ENABLE(CSS_STICKY_POSITION)
    357     bool m_cssStickyPositionEnabled : 1;
    358 #endif
    359348    bool m_showTiledScrollingIndicator : 1;
    360349    bool m_tiledBackingStoreEnabled : 1;
Note: See TracChangeset for help on using the changeset viewer.