Changeset 165252 in webkit

Timestamp:

Mar 6, 2014, 11:20:51 PM (12 years ago)

Author:

akling@apple.com

Message:

WebCoreResourceHandleAsOperationQueueDelegate over-retains NSURLRequest.
<​https://webkit.org/b/129862>

Don't retain the pointer before assigning it to a RetainPtr, since that
will cause the object to leak.

Reviewed by Alexey Proskuryakov.

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate continueWillSendRequest:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-03-06  Andreas Kling  <akling@apple.com>
+
+        WebCoreResourceHandleAsOperationQueueDelegate over-retains NSURLRequest.
+        <https://webkit.org/b/129862>
+
+        Don't retain the pointer before assigning it to a RetainPtr, since that
+        will cause the object to leak.
+
+        Reviewed by Alexey Proskuryakov.
+
+        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+        (-[WebCoreResourceHandleAsOperationQueueDelegate continueWillSendRequest:]):
+
 2014-03-06  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm

@@ -78 +78 @@
 - (void)continueWillSendRequest:(NSURLRequest *)newRequest
 {
-    m_requestResult = [newRequest retain];
+    m_requestResult = newRequest;
     dispatch_semaphore_signal(m_semaphore);
 }