Changeset 165460 in webkit

Timestamp:

Mar 11, 2014, 8:47:16 PM (11 years ago)

Author:

mmaxfield@apple.com

Message:

Some images are blank in the rebaseline server UI
​https://bugs.webkit.org/show_bug.cgi?id=130104

Reviewed by Tim Horton.

Let the server check for images in the 'retries' directory
if it can't find an image otherwise.

• Scripts/webkitpy/tool/servers/rebaselineserver.py:

(RebaselineHTTPRequestHandler.test_result):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/servers/rebaselineserver.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Some images are blank in the rebaseline server UI
+        https://bugs.webkit.org/show_bug.cgi?id=130104
+
+        Reviewed by Tim Horton.
+
+        Let the server check for images in the 'retries' directory
+        if it can't find an image otherwise.
+
+        * Scripts/webkitpy/tool/servers/rebaselineserver.py:
+        (RebaselineHTTPRequestHandler.test_result):
+
 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 

trunk/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

@@ -281 +281 @@
 
         file_path = os.path.join(self.server.test_config.results_directory, file_name)
+        if not os.path.isfile(file_path):
+            file_path = os.path.join(self.server.test_config.results_directory, 'retries', file_name)
 
         # Let results be cached for 60 seconds, so that they can be pre-fetched