Changeset 170951 in webkit

Timestamp:

Jul 9, 2014, 9:13:37 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
​https://bugs.webkit.org/show_bug.cgi?id=134759

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.

Add new API in ewk_download_job.h to get size of the data already downloaded.

• UIProcess/API/efl/ewk_download_job.cpp:

(ewk_download_job_received_data_length_get):
(EwkDownloadJob::receivedData):

• UIProcess/API/efl/ewk_download_job.h:
• UIProcess/API/efl/ewk_download_job_private.h:
• UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_finished):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/ewk_download_job.cpp (modified) (1 diff)
• UIProcess/API/efl/ewk_download_job.h (modified) (1 diff)
• UIProcess/API/efl/ewk_download_job_private.h (modified) (1 diff)
• UIProcess/API/efl/tests/test_ewk2_download_job.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-09  Shivakumar JM  <shiva.jm@samsung.com>
+
+        [EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
+        https://bugs.webkit.org/show_bug.cgi?id=134759
+
+        Reviewed by Gyuyoung Kim.
+
+        Add new API in ewk_download_job.h to get size of the data already downloaded.
+
+        * UIProcess/API/efl/ewk_download_job.cpp:
+        (ewk_download_job_received_data_length_get):
+        (EwkDownloadJob::receivedData):
+        * UIProcess/API/efl/ewk_download_job.h:
+        * UIProcess/API/efl/ewk_download_job_private.h:
+        * UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
+        (EWK2DownloadJobTest::on_download_requested):
+        (EWK2DownloadJobTest::on_download_finished):
+
 2014-07-09  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp

@@ -204 +204 @@
 }
 
+uint64_t ewk_download_job_received_data_size_get(const Ewk_Download_Job* download)
+{
+    EWK_OBJ_GET_IMPL_OR_RETURN(const EwkDownloadJob, download, impl, 0);
+
+    return impl->receivedDataSize();
+}
+
+uint64_t EwkDownloadJob::receivedDataSize() const
+{
+    return m_downloaded;
+}
+
 /**
  * @internal

trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h

@@ -184 +184 @@
 EAPI double ewk_download_job_elapsed_time_get(const Ewk_Download_Job *download);
 
+/**
+ * Gets the data size, already downloaded.
+ *
+ * If the download finished, had an error or was cancelled this is
+ * the data size between its start and the end.
+ *
+ * @param download a #Ewk_Download_Job to query.
+ *
+ * @return the size of the data already downloaded, since the download was started or 0.0 in case of failure.
+ */
+EAPI uint64_t ewk_download_job_received_data_size_get(const Ewk_Download_Job *download);
+
 #ifdef __cplusplus
 }

trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h

@@ -69 +69 @@
     double elapsedTime() const;
     void incrementReceivedData(uint64_t length);
+    uint64_t receivedDataSize() const;
 
 private:

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp

@@ -104 +104 @@
         ASSERT_EQ(0, ewk_download_job_estimated_progress_get(download));
         ASSERT_EQ(0, ewk_download_job_elapsed_time_get(download));
+        ASSERT_EQ(0, ewk_download_job_received_data_size_get(download));
 
         Ewk_Url_Request* request = ewk_download_job_request_get(download);
@@ -143 +144 @@
         ASSERT_EQ(EWK_DOWNLOAD_JOB_STATE_FINISHED, ewk_download_job_state_get(download));
         ASSERT_GT(ewk_download_job_elapsed_time_get(download), 0);
+        ASSERT_GT(ewk_download_job_received_data_size_get(download), 0);
 
         ASSERT_TRUE(fileExists(testData->destinationPath));