Changeset 170991 in webkit

Timestamp:

Jul 10, 2014, 10:06:55 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Debugger Continue button is incorrectly sized
​https://bugs.webkit.org/show_bug.cgi?id=134786

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-10
Reviewed by Timothy Hatcher.

Before this patch everything in the DebuggerDashboardView was flexing.
Normally, if the contents were not too wide, this would just behave
as expected and be centered. If the content was too wide, then each
element would flex uniformly and overlap uniformly. That was not expected.

This patch changes makes everything but the link have a non-flexible
size. If the link (at the end) flexs it will have a nice ellipsis
text truncation, and the rest of the content will be left justified.

This also fixes a few other minor issues seen in the view.

• UserInterface/Views/DebuggerDashboardView.css:

(.dashboard.debugger .navigation-bar):
Reduce the complexity, give the nav bar (the resume button) some simple padding.

(.dashboard.debugger > div):
Make everything non-flex by default.

(.dashboard.debugger > .location):
The location will have an inner element flex, so make it flex.

(.dashboard.debugger > .location > *):
Make everything in .location non-flex by default.

(.dashboard.debugger > .location .go-to-link):
Make the link flex and truncate cleanly.

(.dashboard.debugger > .location .function-name):
Fix vertical alignment when the toolbar has small icons.

• UserInterface/Views/DebuggerDashboardView.js:

(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
Fix class name spelling.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DebuggerDashboardView.css (modified) (4 diffs)
• UserInterface/Views/DebuggerDashboardView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-07-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Debugger Continue button is incorrectly sized
+        https://bugs.webkit.org/show_bug.cgi?id=134786
+
+        Reviewed by Timothy Hatcher.
+
+        Before this patch everything in the DebuggerDashboardView was flexing.
+        Normally, if the contents were not too wide, this would just behave
+        as expected and be centered. If the content was too wide, then each
+        element would flex uniformly and overlap uniformly. That was not expected.
+
+        This patch changes makes everything but the link have a non-flexible
+        size. If the link (at the end) flexs it will have a nice ellipsis
+        text truncation, and the rest of the content will be left justified.
+
+        This also fixes a few other minor issues seen in the view.
+
+        * UserInterface/Views/DebuggerDashboardView.css:
+        (.dashboard.debugger .navigation-bar):
+        Reduce the complexity, give the nav bar (the resume button) some simple padding.
+
+        (.dashboard.debugger > div):
+        Make everything non-flex by default.
+
+        (.dashboard.debugger > .location):
+        The location will have an inner element flex, so make it flex.
+
+        (.dashboard.debugger > .location > *):
+        Make everything in .location non-flex by default.
+
+        (.dashboard.debugger > .location .go-to-link):
+        Make the link flex and truncate cleanly.
+
+        (.dashboard.debugger > .location .function-name):
+        Fix vertical alignment when the toolbar has small icons.
+
+        * UserInterface/Views/DebuggerDashboardView.js:
+        (WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
+        Fix class name spelling.
+
 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css

@@ -41 +41 @@
 .dashboard.debugger .navigation-bar {
     border: 0;
-    margin: 0 5px 0 -5px;
+    margin-right: 4px;
 }
 
@@ -86 +86 @@
     display: -webkit-flex;
     -webkit-align-items: center;
+    -webkit-flex: none;
+}
+
+.dashboard.debugger > .location {
+    -webkit-flex: initial;
+}
+
+.dashboard.debugger > .location > * {
+    -webkit-flex: none;
 }
 
@@ -106 +115 @@
 .dashboard.debugger > .location .function-name {
     color: rgb(30, 30, 30);
+    padding-bottom: 1px;
 }
 
@@ -115 +125 @@
     padding-bottom: 1px;
     -webkit-text-decoration-color: #aaa;
+    
+    -webkit-flex: initial;
+    text-overflow: ellipsis;
+    overflow: hidden;
 }
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js

@@ -62 +62 @@
 WebInspector.DebuggerDashboardView.DividerStyleClassName = "divider";
 WebInspector.DebuggerDashboardView.LocationStyleClassName = "location";
-WebInspector.DebuggerDashboardView.FunctionNameStyleClassname = "function-name";
+WebInspector.DebuggerDashboardView.FunctionNameStyleClassName = "function-name";
 
 WebInspector.DebuggerDashboardView.prototype = {
@@ -95 +95 @@
         var nameElement = document.createElement("div");
         nameElement.appendChild(document.createTextNode(functionName));
-        nameElement.classList.add(WebInspector.DebuggerDashboardView.FunctionNameStyleClassname);
+        nameElement.classList.add(WebInspector.DebuggerDashboardView.FunctionNameStyleClassName);
         this._locationElement.appendChild(nameElement);