Changeset 171114 in webkit

Timestamp:

Jul 15, 2014, 1:52:12 PM (11 years ago)

Author:

enrica@apple.com

Message:

REGRESSION(WK2 iOS): Safari hangs when switching focus from a field using the Tab key.
​https://bugs.webkit.org/show_bug.cgi?id=134934
<rdar://problem/17224638>

Reviewed by Tim Horton.

• UIProcess/ios/WKContentViewInteraction.mm:

Tab and back tab should be handled as special keys that have
a command associated. The command specifies for each key the relevant
action. This patch implements the commands property to create the association
between key and command and the relevant actions that will execute the same
code executed when the used taps on the < > buttons in the accessory bar.

(-[WKContentView keyCommands]):
(-[WKContentView _nextAccessoryTab:]):
(-[WKContentView _prevAccessoryTab:]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-15  Enrica Casucci  <enrica@apple.com>
+
+        REGRESSION(WK2 iOS): Safari hangs when switching focus from a field using the Tab key.
+        https://bugs.webkit.org/show_bug.cgi?id=134934
+        <rdar://problem/17224638>
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        
+        Tab and back tab should be handled as special keys that have
+        a command associated. The command specifies for each key the relevant
+        action. This patch implements the commands property to create the association
+        between key and command and the relevant actions that will execute the same
+        code executed when the used taps on the < > buttons in the accessory bar.
+        
+        (-[WKContentView keyCommands]):
+        (-[WKContentView _nextAccessoryTab:]):
+        (-[WKContentView _prevAccessoryTab:]):
+
 2014-07-15  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm

@@ -1797 +1797 @@
 }
 
+- (NSArray *)keyCommands
+{
+    return @[[UIKeyCommand keyCommandWithInput:@"\t" modifierFlags:0 action:@selector(_nextAccessoryTab:)],
+             [UIKeyCommand keyCommandWithInput:@"\t" modifierFlags:UIKeyModifierShift action:@selector(_prevAccessoryTab:)]];
+}
+
+- (void)_nextAccessoryTab:(id)sender
+{
+    [self accessoryTab:YES];
+}
+
+- (void)_prevAccessoryTab:(id)sender
+{
+    [self accessoryTab:NO];
+}
+
 - (void)accessoryTab:(BOOL)isNext
 {