Changeset 172530 in webkit

Timestamp:

Aug 13, 2014, 12:12:07 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Incorrect border colors in event listeners sections in details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=135891

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

• UserInterface/Views/DetailsSection.css:

(.details-section .details-section > .header):
(.details-section .details-section:not(.collapsed) > .header):
Remove box-shadow and replace with a bottom border.

(body.mac-platform.legacy .details-section .details-section.collapsed > .header):
(.details-section .details-section.collaspsed > .header): Deleted.
Collapsed was spelled incorrectly so this was not applying properly before.
But correct this for legacy because legacy still uses a box-shadow.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DetailsSection.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Incorrect border colors in event listeners sections in details sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=135891
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/DetailsSection.css:
+        (.details-section .details-section > .header):
+        (.details-section .details-section:not(.collapsed) > .header):
+        Remove box-shadow and replace with a bottom border.
+
+        (body.mac-platform.legacy .details-section .details-section.collapsed > .header):
+        (.details-section .details-section.collaspsed > .header): Deleted.
+        Collapsed was spelled incorrectly so this was not applying properly before.
+        But correct this for legacy because legacy still uses a box-shadow.
+
 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css

@@ -90 +90 @@
     background-color: rgb(255, 255, 255);
 
-    box-shadow: rgba(0, 0, 0, 0.1) 0 1px 0;
-
     /* Ensure these headers are displayed below the parent header but above scrollbars. */
     z-index: 100;
-
+}
+
+.details-section .details-section:not(.collapsed) > .header {
+    border-bottom: 1px solid rgb(222, 222, 222);
 }
 
@@ -103 +104 @@
 }
 
-.details-section .details-section.collaspsed > .header {
+body.mac-platform.legacy .details-section .details-section.collapsed > .header {
     box-shadow: none;
 }