Changeset 173015 in webkit

Timestamp:

Aug 27, 2014, 1:19:33 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Layout issues for popover on not legacy OS
​https://bugs.webkit.org/show_bug.cgi?id=136268

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-27
Reviewed by Joseph Pecoraro.

On the latest OS, popovers invade the title bar's space which will
cause layout issues because the title bar will render above
the popover. Fix this by providing some padding for popovers on
not legacy OSs.

• UserInterface/Views/Popover.js:

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/Popover.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-08-27  Saam Barati  <sbarati@apple.com>
+
+        Web Inspector: Layout issues for popover on not legacy OS
+        https://bugs.webkit.org/show_bug.cgi?id=136268
+
+        Reviewed by Joseph Pecoraro.
+
+        On the latest OS, popovers invade the title bar's space which will
+        cause layout issues because the title bar will render above
+        the popover. Fix this by providing some padding for popovers on 
+        not legacy OSs.
+
+        * UserInterface/Views/Popover.js:
+
 2014-08-27  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js

@@ -197 +197 @@
         }
 
+        const titleBarOffset = WebInspector.Platform.name === "mac" && !WebInspector.Platform.isLegacyMacOS ? 22 : 0;
+        var containerFrame = new WebInspector.Rect(0, titleBarOffset, window.innerWidth, window.innerHeight - titleBarOffset);
         // The frame of the window with a little inset to make sure we have room for shadows.
-        var containerFrame = new WebInspector.Rect(0, 0, window.innerWidth, window.innerHeight);
         containerFrame = containerFrame.inset(WebInspector.Popover.ShadowEdgeInsets);