Changeset 177232 in webkit

Timestamp:

Dec 12, 2014, 1:05:07 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

Remove the concept of simple selector from the parser
​https://bugs.webkit.org/show_bug.cgi?id=139575

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-12-12
Reviewed by Mark Lam.

We have complete support for nested selector list, we no longer
need the old concept of simple selector.

• css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::isSimple): Deleted.

• css/CSSParserValues.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParserValues.cpp (modified) (1 diff)
• css/CSSParserValues.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-12-12  Benjamin Poulain  <bpoulain@apple.com>
+
+        Remove the concept of simple selector from the parser
+        https://bugs.webkit.org/show_bug.cgi?id=139575
+
+        Reviewed by Mark Lam.
+
+        We have complete support for nested selector list, we no longer
+        need the old concept of simple selector.
+
+        * css/CSSParserValues.cpp:
+        (WebCore::CSSParserSelector::isSimple): Deleted.
+        * css/CSSParserValues.h:
+
 2014-12-12  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/CSSParserValues.cpp

@@ -282 +282 @@
 }
 
-bool CSSParserSelector::isSimple() const
-{
-    if (m_selector->selectorList() || m_selector->matchesPseudoElement())
-        return false;
-
-    if (!m_tagHistory)
-        return true;
-
-    if (m_selector->match() == CSSSelector::Tag) {
-        // We can't check against anyQName() here because namespace may not be nullAtom.
-        // Example:
-        //     @namespace "http://www.w3.org/2000/svg";
-        //     svg:not(:root) { ...
-        if (m_selector->tagQName().localName() == starAtom)
-            return m_tagHistory->isSimple();
-    }
-
-    return false;
-}
-
 static bool selectorListMatchesPseudoElement(const CSSSelectorList* selectorList)
 {

trunk/Source/WebCore/css/CSSParserValues.h

@@ -219 +219 @@
     }
 
-    bool isSimple() const;
     bool hasShadowDescendant() const;
     bool matchesPseudoElement() const;